-
-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PickleSerializer removed from Django main #646
Comments
…ers.PickleSerializer for django > 4.2
@iurisilvio prepared PR to skip the test that uses PickleSerializer for Django > 4.2. As the |
but what will be used as default then? |
Django removed the serializer, but their redis serializer still use pickle. |
We use django PickleSerializer only to test sessions. https://docs.djangoproject.com/en/4.1/topics/http/sessions/#session-serialization Django changed sessions to work with a json serializer and it is their default now. I'm not sure if in the past the default was pickle. django-redis/tests/test_session.py Line 306 in 5bf67ab
Looks like our test is based on Django test for it and they changed it some time ago. django/django@4368627 I think we should just update the test. |
Pickle was necessary to serialize session expiration, but now Django save it as string. |
#646, fix skip tests for the django.contrib.sessions.serializers.Pick…
Fixed in #647 |
PickleSerializer was deprecated and removed from Django.
https://code.djangoproject.com/ticket/29708
Actions for Django main are broken. https://github.com/jazzband/django-redis/actions/runs/3956633560/jobs/6776067867#step:7:154
The text was updated successfully, but these errors were encountered: