Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#609, use pipeline for delete_pattern #617

Merged
merged 2 commits into from
Oct 21, 2022
Merged

Conversation

rootart
Copy link
Contributor

@rootart rootart commented Jul 5, 2022

Speed up deleting multiple keys by a pattern with pipelines and larger itersize value #609

@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #617 (c9e7daa) into master (38e630f) will increase coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff            @@
##           master    #617     +/-   ##
========================================
+ Coverage    83.3%   83.3%   +0.1%     
========================================
  Files          21      21             
  Lines        1043    1045      +2     
========================================
+ Hits          868     870      +2     
  Misses        175     175             
Flag Coverage Δ
tests 83.3% <100.0%> (+0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
django_redis/client/default.py 88.9% <100.0%> (+0.1%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Member

@WisdomPill WisdomPill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@WisdomPill
Copy link
Member

WisdomPill commented Jul 15, 2022

can you add a changelog file?

@rootart
Copy link
Contributor Author

rootart commented Jul 23, 2022

@WisdomPill, I added changelog details. Thank you for pointing to this.

Copy link
Member

@WisdomPill WisdomPill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry for the huge delay. 😅

@WisdomPill WisdomPill merged commit 1e865a3 into jazzband:master Oct 21, 2022
@foarsitter foarsitter mentioned this pull request Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants