Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mypy errors #626

Merged
merged 2 commits into from
Nov 7, 2022
Merged

Fix mypy errors #626

merged 2 commits into from
Nov 7, 2022

Conversation

foarsitter
Copy link
Contributor

The github actions fail because of some inconvenient mypy cases, this pull request address them.

@codecov
Copy link

codecov bot commented Nov 6, 2022

Codecov Report

Merging #626 (e611a62) into master (2e40dc6) will decrease coverage by 26.0%.
The diff coverage is 66.7%.

@@            Coverage Diff            @@
##           master    #626      +/-   ##
=========================================
- Coverage    83.3%   57.4%   -25.9%     
=========================================
  Files          21      39      +18     
  Lines        1045    2515    +1470     
  Branches        0      74      +74     
=========================================
+ Hits          870    1442     +572     
- Misses        175    1057     +882     
- Partials        0      16      +16     
Flag Coverage Δ
mypy 33.6% <66.7%> (?)
tests 83.3% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_backend.py 14.4% <0.0%> (ø)
tests/conftest.py 100.0% <100.0%> (ø)
django_redis/pool.py 77.0% <0.0%> (-13.4%) ⬇️
django_redis/client/sharded.py 86.1% <0.0%> (-6.6%) ⬇️
django_redis/client/sentinel.py 77.3% <0.0%> (-3.6%) ⬇️
django_redis/client/herd.py 23.4% <0.0%> (-2.4%) ⬇️
django_redis/cache.py 97.0% <0.0%> (-2.2%) ⬇️
django_redis/serializers/pickle.py 100.0% <0.0%> (ø)
tests/settings/sqlite_sentinel.py 100.0% <0.0%> (ø)
tests/settings/sqlite.py 100.0% <0.0%> (ø)
... and 23 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

tests/test_backend.py Outdated Show resolved Hide resolved
@WisdomPill
Copy link
Member

thanks for the contribution!

@WisdomPill WisdomPill merged commit 7712d31 into jazzband:master Nov 7, 2022
@foarsitter
Copy link
Contributor Author

Thank you for your quick response and maintaining this package!

@foarsitter foarsitter deleted the fix_mypy branch November 7, 2022 13:16
@foarsitter foarsitter mentioned this pull request Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants