Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI, with Python 3.6 support. #643

Merged
merged 8 commits into from
Jan 19, 2023
Merged

Fix CI, with Python 3.6 support. #643

merged 8 commits into from
Jan 19, 2023

Conversation

iurisilvio
Copy link
Contributor

Fix #642.

@codecov
Copy link

codecov bot commented Jan 7, 2023

Codecov Report

Merging #643 (6eca196) into master (040d85e) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #643   +/-   ##
======================================
  Coverage    57.4%   57.4%           
======================================
  Files          39      39           
  Lines        2523    2523           
  Branches       75      75           
======================================
  Hits         1448    1448           
  Misses       1058    1058           
  Partials       17      17           
Flag Coverage Δ
mypy 33.7% <ø> (ø)
tests 83.7% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@iurisilvio iurisilvio changed the title Config passenv is comma separated since tox 4.0. Fix CI Jan 7, 2023
@iurisilvio iurisilvio changed the title Fix CI Fix CI, with Python 3.6 support. Jan 7, 2023
Copy link
Member

@WisdomPill WisdomPill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

just one question on ubuntu version

.github/workflows/ci.yml Show resolved Hide resolved
@iurisilvio iurisilvio merged commit 2ba6b15 into jazzband:master Jan 19, 2023
@foarsitter foarsitter mentioned this pull request Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tox>=4 passenv should be comma separated
2 participants