Connection factory goes to cache options #680

RealFatCat · 2023-09-12T09:58:33Z

Another view for #619

codecov · 2023-09-19T16:02:47Z

Codecov Report

Merging #680 (77097d3) into master (c85f609) will increase coverage by 0.5%.
Report is 7 commits behind head on master.
The diff coverage is 76.1%.

@@           Coverage Diff            @@
##           master    #680     +/-   ##
========================================
+ Coverage    60.0%   60.5%   +0.5%     
========================================
  Files          39      41      +2     
  Lines        2534    2605     +71     
  Branches       69      69             
========================================
+ Hits         1520    1575     +55     
- Misses       1001    1017     +16     
  Partials       13      13

Flag	Coverage Δ
mypy	`35.1% <71.9%> (+1.1%)`	⬆️
tests	`89.7% <100.0%> (+0.2%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
django_redis/pool.py	`78.7% <100.0%> (+1.7%)`	⬆️
tests/settings/sqlite_sentinel_opts.py	`100.0% <100.0%> (ø)`
tests/test_connection_factory.py	`48.5% <48.5%> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

WisdomPill

almost there!

nicely done!

WisdomPill · 2023-09-19T16:04:12Z

tests/test_connection_string.py

+            "SENTINELS": [("127.0.0.1", "26739")],
+        },
+    )
+    res = cf.make_connection_params(connection_string)


why check connection params?

why not check if CF is an instance of SentinelConnectionFactory? I would even use multiple connection factories from parametrize and check that the same instance is created

RealFatCat · 2023-09-25T12:42:38Z

Added some tests for get_connection_factory.

akostrikov · 2023-09-26T14:27:02Z

Wow, nice feature! I really want to see that in production

WisdomPill

LGTM!

WisdomPill · 2023-09-26T15:37:31Z

last but not least is to add a changelog file so that when the release is made the CHANGELOG is automatic

RealFatCat · 2023-09-26T18:38:38Z

last but not least is to add a changelog file so that when the release is made the CHANGELOG is automatic

done

akostrikov · 2023-09-29T15:04:50Z

@WisdomPill Hello, Anas! Any info on when the next release is going to be?

WisdomPill · 2023-09-29T16:01:42Z

this weekend

…9524) Bumps [django-redis](https://github.com/jazzband/django-redis) from 5.3.0 to 5.4.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/jazzband/django-redis/releases">django-redis's releases</a>.</em></p> <blockquote> <h2>5.4.0</h2> <h1>django-redis 5.4.0 (2023-10-01)</h1> <h2>Features</h2> <ul> <li>Connection factory goes to cache options (<code>[#680](jazzband/django-redis#680) <https://github.com/jazzband/django-redis/issues/680></code>_)</li> </ul> <h2>Documentation</h2> <ul> <li>Added note in docs for correctly configuring hiredis parser when using redis-py version 5. (<code>[#677](jazzband/django-redis#677) <https://github.com/jazzband/django-redis/issues/677></code>_)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/jazzband/django-redis/blob/master/CHANGELOG.rst">django-redis's changelog</a>.</em></p> <blockquote> <h1>django-redis 5.4.0 (2023-10-01)</h1> <h2>Features</h2> <ul> <li>Connection factory goes to cache options (<code>[#680](jazzband/django-redis#680) <https://github.com/jazzband/django-redis/issues/680></code>_)</li> </ul> <h2>Documentation</h2> <ul> <li>Added note in docs for correctly configuring hiredis parser when using redis-py version 5. (<code>[#677](jazzband/django-redis#677) <https://github.com/jazzband/django-redis/issues/677></code>_)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/jazzband/django-redis/commit/2a3770f17c3f1dc3ace95d3cfcc3c3edde9784eb"><code>2a3770f</code></a> Merge pull request <a href="https://redirect.github.com/jazzband/django-redis/issues/683">#683</a> from WisdomPill/release540</li> <li><a href="https://github.com/jazzband/django-redis/commit/c09ad9bd916b65adfd9d0ee2e7caf455a25ffaee"><code>c09ad9b</code></a> Preparing release 5.4.0</li> <li><a href="https://github.com/jazzband/django-redis/commit/a582fe4ae9b8d05e265b4b072b12d3ca2e3b2489"><code>a582fe4</code></a> Merge pull request <a href="https://redirect.github.com/jazzband/django-redis/issues/680">#680</a> from RealFatCat/feat/connection-factory-in-cache-options</li> <li><a href="https://github.com/jazzband/django-redis/commit/77097d3fde4b061281b1e2d3a182adf7f6035da3"><code>77097d3</code></a> Connection factory goes to cache options</li> <li><a href="https://github.com/jazzband/django-redis/commit/097c9973bd82c043a885e82a88841983da392f9f"><code>097c997</code></a> Merge pull request <a href="https://redirect.github.com/jazzband/django-redis/issues/681">#681</a> from jazzband/pre-commit-ci-update-config</li> <li><a href="https://github.com/jazzband/django-redis/commit/541dbb4a073d8e049dff8dca8594fdae5942ed77"><code>541dbb4</code></a> [pre-commit.ci] pre-commit autoupdate</li> <li><a href="https://github.com/jazzband/django-redis/commit/891aa48585bdd9e862ba3b9ade73be4dc81aa850"><code>891aa48</code></a> Merge pull request <a href="https://redirect.github.com/jazzband/django-redis/issues/679">#679</a> from jazzband/pre-commit-ci-update-config</li> <li><a href="https://github.com/jazzband/django-redis/commit/d79f4c9d9d613a96cbcbcae2f92972460d269f35"><code>d79f4c9</code></a> [pre-commit.ci] pre-commit autoupdate</li> <li><a href="https://github.com/jazzband/django-redis/commit/361921841eb07315cc88ff83a1889fec43a89242"><code>3619218</code></a> Merge pull request <a href="https://redirect.github.com/jazzband/django-redis/issues/677">#677</a> from jazzband/readme-patch-1</li> <li><a href="https://github.com/jazzband/django-redis/commit/c85f609837d760f9f7d50a4390552746d15feca9"><code>c85f609</code></a> Create 677.doc</li> <li>Additional commits viewable in <a href="https://github.com/jazzband/django-redis/compare/5.3.0...5.4.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=django-redis&package-manager=pip&previous-version=5.3.0&new-version=5.4.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

RealFatCat mentioned this pull request Sep 18, 2023

Why does DJANGO_REDIS_CONNECTION_FACTORY need to be a global django setting ? #619

Closed

WisdomPill requested changes Sep 19, 2023

View reviewed changes

RealFatCat force-pushed the feat/connection-factory-in-cache-options branch 2 times, most recently from c892599 to e245d5d Compare September 25, 2023 12:39

WisdomPill approved these changes Sep 26, 2023

View reviewed changes

Connection factory goes to cache options

77097d3

RealFatCat force-pushed the feat/connection-factory-in-cache-options branch from e245d5d to 77097d3 Compare September 26, 2023 18:37

WisdomPill merged commit a582fe4 into jazzband:master Sep 28, 2023
28 checks passed

foarsitter mentioned this pull request Nov 1, 2023

Pin pytest to <7 #691

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Connection factory goes to cache options #680

Connection factory goes to cache options #680

RealFatCat commented Sep 12, 2023

codecov bot commented Sep 19, 2023 •

edited

Loading

WisdomPill left a comment

WisdomPill Sep 19, 2023

RealFatCat commented Sep 25, 2023

akostrikov commented Sep 26, 2023

WisdomPill left a comment

WisdomPill commented Sep 26, 2023 •

edited

Loading

RealFatCat commented Sep 26, 2023

akostrikov commented Sep 29, 2023

WisdomPill commented Sep 29, 2023

Connection factory goes to cache options #680

Connection factory goes to cache options #680

Conversation

RealFatCat commented Sep 12, 2023

codecov bot commented Sep 19, 2023 • edited Loading

Codecov Report

WisdomPill left a comment

Choose a reason for hiding this comment

WisdomPill Sep 19, 2023

Choose a reason for hiding this comment

RealFatCat commented Sep 25, 2023

akostrikov commented Sep 26, 2023

WisdomPill left a comment

Choose a reason for hiding this comment

WisdomPill commented Sep 26, 2023 • edited Loading

RealFatCat commented Sep 26, 2023

akostrikov commented Sep 29, 2023

WisdomPill commented Sep 29, 2023

codecov bot commented Sep 19, 2023 •

edited

Loading

WisdomPill commented Sep 26, 2023 •

edited

Loading