Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added silk_request_garbage_collect command for out-of-band garbage collection. #541

Merged
merged 3 commits into from
Jun 20, 2022

Conversation

nschlemm
Copy link
Contributor

To avoid deadlock issues as mentioned e.g. in #265 #294 #371
Based on #265 (comment)

@nschlemm nschlemm requested a review from hramezani January 21, 2022 12:31
@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #541 (a785e53) into master (be920b2) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #541      +/-   ##
==========================================
+ Coverage   84.60%   84.72%   +0.11%     
==========================================
  Files          51       52       +1     
  Lines        2059     2075      +16     
==========================================
+ Hits         1742     1758      +16     
  Misses        317      317              
Impacted Files Coverage Δ
...anagement/commands/silk_request_garbage_collect.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be920b2...a785e53. Read the comment docs.

@hramezani
Copy link
Member

Hi @nschlemm, Thanks for mentioning me in this patch and asking for a review.
Unfortunately, I am not involved in this project.
So, you may need to ask project leads for a review.

@nschlemm
Copy link
Contributor Author

nschlemm commented Jan 21, 2022

@hramezani sorry, then github must definitely step up their game for suggesting reviewers ;)

and I can't see an option to "release" you from this mention...

@auvipy as release author of 4.2.0 would you be willing to review this? thx!

@albertyw albertyw requested review from albertyw and removed request for hramezani March 16, 2022 06:18
@albertyw
Copy link
Member

Even when triggered manually through this command, it's still possible for deadlocks to happen unless the database is receiving no other writes during the period. This isn't going to guarantee fixing deadlocks. There should be a full solution made to fix deadlocks, though the ability to manually trigger cleanup perhaps during low-traffic hours is still useful.

@albertyw
Copy link
Member

There are some rebase conflicts. @nschlemm Please rebase and this can be merged.

@albertyw albertyw merged commit c59acba into jazzband:master Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants