Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Django 2.2 (EOL) #567

Merged
merged 1 commit into from
Jun 20, 2022
Merged

Drop support for Django 2.2 (EOL) #567

merged 1 commit into from
Jun 20, 2022

Conversation

ulgens
Copy link
Member

@ulgens ulgens commented May 28, 2022

Depends on #566

@ulgens ulgens requested review from albertyw, jezdez and nasirhjafri May 28, 2022 13:32
@ulgens ulgens self-assigned this May 28, 2022
@codecov
Copy link

codecov bot commented May 28, 2022

Codecov Report

Merging #567 (d85e03e) into master (0f5c994) will decrease coverage by 0.11%.
The diff coverage is n/a.

❗ Current head d85e03e differs from pull request most recent head 62a1991. Consider uploading reports for the commit 62a1991 to get more accurate results

@@            Coverage Diff             @@
##           master     #567      +/-   ##
==========================================
- Coverage   84.60%   84.48%   -0.12%     
==========================================
  Files          51       51              
  Lines        2059     2056       -3     
==========================================
- Hits         1742     1737       -5     
- Misses        317      319       +2     
Impacted Files Coverage Δ
silk/__init__.py 60.00% <ø> (-15.00%) ⬇️
silk/model_factory.py 82.96% <0.00%> (-0.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f5c994...62a1991. Read the comment docs.

@albertyw
Copy link
Member

I see code coverage has dropped but it's only as a result of deleting code.

@albertyw albertyw merged commit 0c8c2c9 into master Jun 20, 2022
@albertyw albertyw deleted the drop_dj22 branch June 20, 2022 05:41
@albertyw
Copy link
Member

I landed this too soon. I'm going to revert this for the v4.4.0 and unrevert this for v5.0.0

albertyw added a commit to albertyw/django-silk that referenced this pull request Jun 20, 2022
albertyw pushed a commit to albertyw/django-silk that referenced this pull request Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants