Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use contextlib in test_profile_parser #590

Merged
merged 2 commits into from
Oct 12, 2022

Conversation

s-t-e-v-e-n-k
Copy link
Contributor

Since the project no longer declares a requirement of contextlib2, and
the lowest version of Python supported is 3.7, we should remove the use
of contextlib2. Switch the import to contextlib.

@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #590 (a18a012) into master (dcbc6e0) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head a18a012 differs from pull request most recent head 4ca96d9. Consider uploading reports for the commit 4ca96d9 to get more accurate results

@@           Coverage Diff           @@
##           master     #590   +/-   ##
=======================================
  Coverage   84.59%   84.60%           
=======================================
  Files          52       52           
  Lines        2071     2072    +1     
=======================================
+ Hits         1752     1753    +1     
  Misses        319      319           
Impacted Files Coverage Δ
silk/model_factory.py 82.96% <0.00%> (-0.08%) ⬇️
silk/collector.py 89.78% <0.00%> (+0.07%) ⬆️
silk/middleware.py 89.42% <0.00%> (+0.10%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@albertyw
Copy link
Member

Can you also edit requirements.txt and remove the contextlib2 dependency there too?

Since the project no longer declares a requirement of contextlib2, and
the lowest version of Python supported is 3.7, we should remove the use
of contextlib2. Switch the import to contextlib.
@albertyw albertyw merged commit e2cf24f into jazzband:master Oct 12, 2022
@albertyw albertyw mentioned this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants