-
-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Outsource all inline scripts and styles #635
Conversation
Codecov Report
@@ Coverage Diff @@
## master #635 +/- ##
=======================================
Coverage 86.33% 86.33%
=======================================
Files 52 52
Lines 2093 2093
=======================================
Hits 1807 1807
Misses 286 286 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@sgelis Sorry, it looks like I accidentally closed this pull request when I tried rebasing it on top of #639 to get the tests to pass. Since the pull request is closed, I also can't push your changes back to your repository fork. Your branch still exists at https://github.com/albertyw/django-silk/tree/sgelis-master but you'll need to grab the code on that branch again, push the changes to github, and reopen this pull request. You can do that with
I also created sgelis#1 as another way to get your commits back in your repository. |
for more information, see https://pre-commit.ci
Sending your django-silk pull request code back to you
Fixes #531.
Tests pass and manual testing shows no regression as far as I can tell.