-
-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow option to delete profiles #652
Allow option to delete profiles #652
Conversation
Updated msg to be displayed with line breaks so new message can be shown in new line.
Added option to check for `SILKY_DELETE_PROFILES` set by user in settings file which if set true, all profiles will be deleted along with database clean function.
Added new configuration setting SILKY_DELETE_PROFILES.
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like correct update.
Codecov Report
@@ Coverage Diff @@
## master #652 +/- ##
==========================================
+ Coverage 86.51% 86.59% +0.07%
==========================================
Files 52 52
Lines 2091 2103 +12
==========================================
+ Hits 1809 1821 +12
Misses 282 282
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Added new test that will test delete all profile functionality.
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added new test case
All checks have passed and the updated code implements helpful functionality. |
Added a new config option that will allow user to clear profiler profiles from storage when Clear DB is called. This is helpful functionality especially in development environment where frequent DB cleaning is done.