Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow option to delete profiles #652

Merged
merged 6 commits into from
Dec 30, 2023

Conversation

viralj
Copy link
Contributor

@viralj viralj commented Apr 6, 2023

Added a new config option that will allow user to clear profiler profiles from storage when Clear DB is called. This is helpful functionality especially in development environment where frequent DB cleaning is done.

viralj and others added 4 commits April 6, 2023 12:58
Updated msg to be displayed with line breaks so new message can be shown in new line.
Added option to check for `SILKY_DELETE_PROFILES` set by user in settings file which if set true, all profiles will be deleted along with database clean function.
Added new configuration setting SILKY_DELETE_PROFILES.
Copy link
Contributor Author

@viralj viralj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like correct update.

@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #652 (8d4b13e) into master (274898f) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #652      +/-   ##
==========================================
+ Coverage   86.51%   86.59%   +0.07%     
==========================================
  Files          52       52              
  Lines        2091     2103      +12     
==========================================
+ Hits         1809     1821      +12     
  Misses        282      282              
Impacted Files Coverage Δ
silk/config.py 90.47% <ø> (ø)
silk/views/clear_db.py 97.29% <100.00%> (+1.29%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

viralj and others added 2 commits April 6, 2023 13:16
Added new test that will test delete all profile functionality.
Copy link
Contributor Author

@viralj viralj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added new test case

@viralj
Copy link
Contributor Author

viralj commented Apr 6, 2023

All checks have passed and the updated code implements helpful functionality.

@albertyw albertyw merged commit f24f055 into jazzband:master Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants