Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make setup.py example equivalent to setup.cfg in test_cli_compile #1605

Merged
merged 2 commits into from
Mar 30, 2022

Conversation

abravalheri
Copy link
Contributor

@abravalheri abravalheri commented Mar 30, 2022

This is an internal/maintenance change to the test suite.

As pointed out in pypa/setuptools#3198 (comment), the tests in:

test_cli_compile.py::test_input_formats[setup.py]
test_cli_compile.py::test_multiple_extras[setup.py-singular]
test_cli_compile.py::test_one_extra[setup.py]
test_cli_compile.py::test_multiple_extras[setup.py-comma-separated]

are currently failing.

After checking the code, it seems that the setup.py file does not match exactly its setup.cfg counterpart and is actually trying to create an empty package. (See pypa/setuptools#3198 (comment)).

The changes introduced here make the setup.py mirror exactly its setup.cfg counterpart.
If instead the intention is to create purposefully empty packages, then setuptools v61 asks the users to explicitly set:

setup(
    ...,
    packages=[]
)

P.S.: I think this change can probably be a #skip-changelog. Please feel free to rename the PR.

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@abravalheri abravalheri marked this pull request as ready for review March 30, 2022 13:48
@AndydeCleyre AndydeCleyre added the skip-changelog Avoid listing in changelog label Mar 30, 2022
@AndydeCleyre AndydeCleyre merged commit ba022e8 into jazzband:master Mar 30, 2022
@atugushev atugushev added the tests Testing and related things label Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Avoid listing in changelog tests Testing and related things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants