Make setup.py example equivalent to setup.cfg in test_cli_compile #1605
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an internal/maintenance change to the test suite.
As pointed out in pypa/setuptools#3198 (comment), the tests in:
test_cli_compile.py::test_input_formats[setup.py]
test_cli_compile.py::test_multiple_extras[setup.py-singular]
test_cli_compile.py::test_one_extra[setup.py]
test_cli_compile.py::test_multiple_extras[setup.py-comma-separated]
are currently failing.
After checking the code, it seems that the
setup.py
file does not match exactly itssetup.cfg
counterpart and is actually trying to create an empty package. (See pypa/setuptools#3198 (comment)).The changes introduced here make the
setup.py
mirror exactly itssetup.cfg
counterpart.If instead the intention is to create purposefully empty packages, then
setuptools v61
asks the users to explicitly set:P.S.: I think this change can probably be a #skip-changelog. Please feel free to rename the PR.
Contributor checklist
Maintainer checklist
backwards incompatible
,feature
,enhancement
,deprecation
,bug
,dependency
,docs
orskip-changelog
as they determine changelog listing.