fix: use main-SNAPSHOT as best-effort fallback for jitpack #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxandersen
force-pushed
the
betterjitpack
branch
from
b55fe25
to
021f062
Compare
maxandersen
force-pushed
the
betterjitpack
branch
from
021f062
to
6c173fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1817 made me bite the bullet and have github urls default to use
main-SNAPSHOTso it wont fail on new stuff. The whole reason I hesitated was that jitpack in past would accept HEAD-SNAPSHOT to pickup whatever is the default name on github (main or master). But that stop working some years ago - back then I hoped it was just a glitch..but since not fixed i'm now at least making it work for new things.also updated the docs and added more tests as things were slightly incorrect.
Fixes #1817