Resolves an error when deploying the webhook where the k8s api indica…

…ted that the webhook config was invalid because of missing SideEffects, and AdmissionReviewVersions (kubeflow#1413)
jbhalodia-slack · Dec 2, 2021 · ba316fa · ba316fa
1 parent 97bca03
commit ba316fa
Showing 1 changed file with 12 additions and 6 deletions.
diff --git a/pkg/webhook/webhook.go b/pkg/webhook/webhook.go
@@ -379,16 +379,20 @@ func (wh *WebHook) selfRegistration(webhookConfigName string) error {
 		},
 	}
 
+	sideEffect := arv1.SideEffectClassNoneOnDryRun
+
 	mutatingWebhook := arv1.MutatingWebhook{
 		Name:  webhookName,
 		Rules: mutatingRules,
 		ClientConfig: arv1.WebhookClientConfig{
 			Service:  wh.serviceRef,
 			CABundle: caCert,
 		},
-		FailurePolicy:     &wh.failurePolicy,
-		NamespaceSelector: wh.selector,
-		TimeoutSeconds:    wh.timeoutSeconds,
+		FailurePolicy:           &wh.failurePolicy,
+		NamespaceSelector:       wh.selector,
+		TimeoutSeconds:          wh.timeoutSeconds,
+		SideEffects:             &sideEffect,
+		AdmissionReviewVersions: []string{"v1"},
 	}
 
 	validatingWebhook := arv1.ValidatingWebhook{
@@ -398,9 +402,11 @@ func (wh *WebHook) selfRegistration(webhookConfigName string) error {
 			Service:  wh.serviceRef,
 			CABundle: caCert,
 		},
-		FailurePolicy:     &wh.failurePolicy,
-		NamespaceSelector: wh.selector,
-		TimeoutSeconds:    wh.timeoutSeconds,
+		FailurePolicy:           &wh.failurePolicy,
+		NamespaceSelector:       wh.selector,
+		TimeoutSeconds:          wh.timeoutSeconds,
+		SideEffects:             &sideEffect,
+		AdmissionReviewVersions: []string{"v1"},
 	}
 
 	mutatingWebhooks := []arv1.MutatingWebhook{mutatingWebhook}