https://github.com/jakartaee/faces/issues/1705

Backport WARNING message into Mojarra 4.0
jboss · May 18, 2023 · e1951b1 · e1951b1
1 parent e30e351
commit e1951b1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/impl/src/main/java/com/sun/faces/facelets/tag/faces/core/MetadataHandler.java b/impl/src/main/java/com/sun/faces/facelets/tag/faces/core/MetadataHandler.java
@@ -58,6 +58,9 @@ public void apply(FaceletContext ctx, UIComponent parent) throws IOException {
             root = (UIViewRoot) parent;
         } else {
             root = ctx.getFacesContext().getViewRoot();
+            if (root != null && LOGGER.isLoggable(Level.WARNING)) {
+                LOGGER.log(Level.WARNING, "faces.metadata.invalid.location", root.getViewId());
+            }
         }
         if (root == null) {
             if (LOGGER.isLoggable(Level.SEVERE)) {

diff --git a/impl/src/main/resources/com/sun/faces/LogStrings.properties b/impl/src/main/resources/com/sun/faces/LogStrings.properties
@@ -127,3 +127,4 @@ faces.context.partial_visit_context_unvisited_children=JSF1098: The following cl
 faces.lifecycle.invalid.referer=JSF1099: Referer [sic] header value {0} does not appear to be a protected view. Preventing display of viewId {1}
 faces.lifecycle.invalid.origin=JSF1100: Origin [sic] header value {0} does not appear to be a protected view. Preventing display of viewId {1}
 faces.externalcontext.flash.force.write.cookie.failed=JSF1102: The system was configured to force writing the flash cookie, but the write failed.
+faces.metadata.invalid.location=JSF1103: The metadata facet must be a direct child of the view in viewId {0}