Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

browser scrolls back to focused element after hover popup closes #7

Closed
jedwards1211 opened this issue Mar 7, 2019 · 2 comments
Closed

browser scrolls back to focused element after hover popup closes #7

jedwards1211 opened this issue Mar 7, 2019 · 2 comments
Assignees
@jedwards1211
Labels
bug Something isn't working released

Comments

@jedwards1211
Copy link
Member

jedwards1211 commented Mar 7, 2019 •
edited
Loading

I think I just need to make the popup request focus when it opens, or blur the focused element.

Repro

  1. Go to https://jcoreio.github.io/material-ui-popup-state/
  2. Click the Show Source icon button at top right
  3. Scroll down to the "Hover to Open Menu" button
  4. Move mouse over the "Hover to Open Menu" button
  5. Move mouse away from button and menu to make the menu close
  6. Page scrolls back to the Show Source button
@jedwards1211 jedwards1211 added the bug Something isn't working label Mar 7, 2019
@jedwards1211 jedwards1211 self-assigned this Mar 7, 2019
@jedwards1211
Copy link
Member Author

🎉 This issue has been resolved in version 1.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jedwards1211
Copy link
Member Author

@oliviertassanari Do you recall if this was an issue with MUI 3? I fixed this issue in the MUI 3 days, but the fix is causing #68. I can't reproduce this issue now though (master is on MUI 4)

jedwards1211 added a commit that referenced this issue Jun 30, 2021
@jedwards1211
fix: revert workaround for #7
c971692 
fix #68

If you're using MUI 3, you may see issue #7 happening again.  If so, you'll need to
investigate the issue with the authors of MUI/decide how to work around it yourself.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jedwards1211 jedwards1211

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jedwards1211