Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(checkbox): add checkbox new props of shape #1978

Merged
merged 2 commits into from
Jan 18, 2023

Conversation

mikasayw
Copy link
Contributor

@mikasayw mikasayw commented Dec 26, 2022

这个 PR 做了什么? (简要描述所做更改)

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue id #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe): add new test case

这个 PR 涉及以下平台:

  • NutUI 2.0
  • NutUI 3.0 H5
  • NutUI 3.0 小程序

这个 PR 是否已自测:

@richard1015 richard1015 requested a review from szg2008 December 28, 2022 08:53
Copy link
Contributor

@szg2008 szg2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1、demo建议单独增加一个示例,不要混合在一起
2、在v4分支也同步下这个功能,包括源码和文档

@szg2008 szg2008 merged commit 68551f2 into jd-opensource:next Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants