Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: overlay 的 zIndex 属性改为 css 变量 #1294

Merged
merged 5 commits into from
Aug 10, 2023
Merged

fix: overlay 的 zIndex 属性改为 css 变量 #1294

merged 5 commits into from
Aug 10, 2023

Conversation

oasis-cloud
Copy link
Collaborator

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复

🔗 相关 Issue

#1286

💡 需求背景和解决方案

Dialog 组件的遮罩层通过 Overlay 实现,通过但是不能传入 zIndex 属性,将 Overlay 的 zIndex 改为 css 变量,可在使用 Dialog 的时候,通过style 改变 Overlay 组件提供的 zIndex 相关的 css 变量的值,从而实现 issue 中的效果

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • fork仓库代码是否为最新避免文件冲突
  • Files changed 没有 package.json lock 等无关文件

@oasis-cloud oasis-cloud changed the title fix: 将 zIndex 属性改为 css 变量 fix: overlay 的 zIndex 属性改为 css 变量 Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #1294 (7b4d058) into next (9a3d339) will increase coverage by 0.00%.
Report is 4 commits behind head on next.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next    #1294   +/-   ##
=======================================
  Coverage   70.78%   70.78%           
=======================================
  Files         200      200           
  Lines        7906     7907    +1     
  Branches     2269     2270    +1     
=======================================
+ Hits         5596     5597    +1     
  Misses       2105     2105           
  Partials      205      205           
Files Changed Coverage Δ
src/packages/fixednav/fixednav.tsx 83.33% <ø> (ø)
src/packages/overlay/overlay.tsx 100.00% <ø> (ø)
src/packages/popup/popup.tsx 90.62% <ø> (ø)

... and 1 file with indirect coverage changes

Copy link
Collaborator

@xiaoyatong xiaoyatong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 检查一下 使用 overlay 的组件,是否有用到zindex,比如 fixednav;
  2. 把dialog里相关废弃的css变量剔除。

@xiaoyatong
Copy link
Collaborator

issue 里提到的 dailog 变量 还是没有删除

@oasis-cloud oasis-cloud merged commit 69ee6b4 into jdf2e:next Aug 10, 2023
@oasis-cloud oasis-cloud deleted the fix/overlay-popup branch August 28, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants