Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(table): props 中的 data 校验逻辑异常 #1675

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Conversation

oasis-cloud
Copy link
Collaborator

🤔 这个变动的性质是?

  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 重构

🔗 相关 Issue

props 中的 data 更新后,内部状态无法同步更新

💡 需求背景和解决方案

通过已经封装的 usePropsValue 解决,而且解决方案也具有一致性

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • fork仓库代码是否为最新避免文件冲突
  • Files changed 没有 package.json lock 等无关文件

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (154e787) 73.40% compared to head (48e1ce5) 73.49%.
Report is 9 commits behind head on next.

Files Patch % Lines
src/packages/table/table.tsx 88.88% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1675      +/-   ##
==========================================
+ Coverage   73.40%   73.49%   +0.09%     
==========================================
  Files         211      211              
  Lines        8539     8546       +7     
  Branches     2414     2413       -1     
==========================================
+ Hits         6268     6281      +13     
+ Misses       2060     2054       -6     
  Partials      211      211              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiaoyatong xiaoyatong self-assigned this Nov 24, 2023
@xiaoyatong
Copy link
Collaborator

关注下 test 数据

@oasis-cloud
Copy link
Collaborator Author

关注下 test 数据

已增加更多单元测试

@xiaoyatong xiaoyatong merged commit 2b92739 into next Nov 29, 2023
@xiaoyatong xiaoyatong deleted the refactor/table branch February 2, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants