Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(popover): 新增属性 action,简化css 变量 #1747

Merged
merged 9 commits into from
Dec 4, 2023

Conversation

xiaoyatong
Copy link
Collaborator

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • fork仓库代码是否为最新避免文件冲突
  • Files changed 没有 package.json lock 等无关文件

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (1bf50ee) 74.06% compared to head (9c7527b) 74.03%.
Report is 3 commits behind head on next.

❗ Current head 9c7527b differs from pull request most recent head 6580c93. Consider uploading reports for the commit 6580c93 to get more accurate results

Files Patch % Lines
src/packages/popover/popover.tsx 42.85% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1747      +/-   ##
==========================================
- Coverage   74.06%   74.03%   -0.03%     
==========================================
  Files         211      211              
  Lines        8575     8581       +6     
  Branches     2432     2437       +5     
==========================================
+ Hits         6351     6353       +2     
- Misses       2016     2019       +3     
- Partials      208      209       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oasis-cloud oasis-cloud merged commit 080f92a into jdf2e:next Dec 4, 2023
3 checks passed
@xiaoyatong xiaoyatong deleted the f-popover branch February 1, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants