Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(table): 增加table锁定头部、左侧列、右侧列 #1775

Merged
merged 25 commits into from
Dec 22, 2023

Conversation

zhehu1
Copy link
Contributor

@zhehu1 zhehu1 commented Dec 11, 2023

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

#1064
https://github.com/jdf2e/nutui-react/issues/445(除行点击)

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • fork仓库代码是否为最新避免文件冲突
  • Files changed 没有 package.json lock 等无关文件

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (2f5d8cc) 74.41% compared to head (e1d1586) 74.58%.
Report is 2 commits behind head on next.

Files Patch % Lines
src/packages/calendaritem/calendaritem.tsx 28.57% 5 Missing ⚠️
src/packages/infiniteloading/infiniteloading.tsx 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1775      +/-   ##
==========================================
+ Coverage   74.41%   74.58%   +0.16%     
==========================================
  Files         213      215       +2     
  Lines        8580     8640      +60     
  Branches     2461     2477      +16     
==========================================
+ Hits         6385     6444      +59     
- Misses       1983     1984       +1     
  Partials      212      212              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/packages/table/demo.taro.tsx Outdated Show resolved Hide resolved
src/packages/table/demo.tsx Outdated Show resolved Hide resolved
src/packages/table/doc.en-US.md Outdated Show resolved Hide resolved
src/packages/table/table.scss Outdated Show resolved Hide resolved
src/packages/table/table.taro.tsx Show resolved Hide resolved
src/packages/table/table.tsx Outdated Show resolved Hide resolved
@xiaoyatong
Copy link
Collaborator

image

Copy link
Collaborator

@xiaoyatong xiaoyatong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文档里需要加上demo~~

src/styles/variables-jmapp.scss Outdated Show resolved Hide resolved
</div>
{isSticky ? (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这部分是不是可以放在 wrapper 中?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

和结构有关,现在放到wrapper会阴影会随着滚动条滚走

@zhehu1 zhehu1 requested a review from xiaoyatong December 21, 2023 10:03
@xiaoyatong xiaoyatong changed the title feat(table): 增加table锁定能力 feat(table): 增加table锁定头部、左侧列、右侧列 Dec 22, 2023
@xiaoyatong xiaoyatong merged commit 96e94b2 into jdf2e:next Dec 22, 2023
5 checks passed
@zhehu1 zhehu1 deleted the f-table branch March 18, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants