Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(swiper): implementing sliding logic through useTouch #1793

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

oasis-cloud
Copy link
Collaborator

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • fork仓库代码是否为最新避免文件冲突
  • Files changed 没有 package.json lock 等无关文件

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (e3c03c8) 74.18% compared to head (669cfe8) 74.29%.
Report is 1 commits behind head on next.

Files Patch % Lines
src/packages/swiper/swiper.tsx 61.53% 28 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1793      +/-   ##
==========================================
+ Coverage   74.18%   74.29%   +0.11%     
==========================================
  Files         211      211              
  Lines        8629     8597      -32     
  Branches     2468     2463       -5     
==========================================
- Hits         6401     6387      -14     
+ Misses       2016     1998      -18     
  Partials      212      212              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/packages/swiper/swiper.tsx Outdated Show resolved Hide resolved
src/packages/swiper/swiper.tsx Outdated Show resolved Hide resolved
@oasis-cloud oasis-cloud changed the title refactor(swiper): 通过 useTouch 实现滑动逻辑 refactor(swiper): implementing sliding logic through useTouch Dec 15, 2023
@oasis-cloud oasis-cloud merged commit 2906ef1 into jdf2e:next Dec 15, 2023
4 of 5 checks passed
@oasis-cloud oasis-cloud deleted the refactor/swiper branch December 15, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants