Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(InfiniteLoading): 修改类名及demo #1818

Merged
merged 37 commits into from
Dec 28, 2023

Conversation

xiaoyatong
Copy link
Collaborator

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • fork仓库代码是否为最新避免文件冲突
  • Files changed 没有 package.json lock 等无关文件

Copy link

codecov bot commented Dec 25, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f6675e0) 74.59% compared to head (ffe34cf) 75.05%.
Report is 4 commits behind head on next.

Files Patch % Lines
src/packages/infiniteloading/infiniteloading.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1818      +/-   ##
==========================================
+ Coverage   74.59%   75.05%   +0.45%     
==========================================
  Files         215      215              
  Lines        8651     8650       -1     
  Branches     2476     2475       -1     
==========================================
+ Hits         6453     6492      +39     
+ Misses       1986     1951      -35     
+ Partials      212      207       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@oasis-cloud oasis-cloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以在升级文档中标记下,对应的修改方式。降低用户使用困扰。
或者在 PR 中描述下修改方案,这样也可以让开发者直接查看 PR 中的描述,进行对应的修改。
建议以后得改动都在 PR 中标注出原因,升级方案等相关信息。

@oasis-cloud oasis-cloud merged commit 0558d90 into jdf2e:next Dec 28, 2023
4 of 5 checks passed
@xiaoyatong xiaoyatong deleted the f-infiniteloading branch February 1, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants