feat(dialog): 增加关闭按钮 #1872
Merged
feat(dialog): 增加关闭按钮 #1872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #1872 +/- ##
==========================================
+ Coverage 75.87% 75.92% +0.05%
==========================================
Files 215 215
Lines 8662 8673 +11
Branches 2480 2484 +4
==========================================
+ Hits 6572 6585 +13
+ Misses 1893 1891 -2
Partials 197 197 ☔ View full report in Codecov by Sentry. |
oasis-cloud
requested changes
Jan 18, 2024
| @@ -25,6 +26,8 @@ const defaultProps = { | |||
| disableConfirmButton: false, | |||
| footerDirection: 'horizontal', | |||
| lockScroll: true, | |||
| closeIconPosition: 'top-right', | |||
There was a problem hiding this comment.
增加类型，明确可以使用哪些组合
已修改
oasis-cloud
requested changes
Jan 18, 2024
| @@ -32,6 +33,8 @@ const defaultProps = { | |||
| disableConfirmButton: false, | |||
| footerDirection: 'horizontal', | |||
| lockScroll: true, | |||
| closeIconPosition: 'top-right', | |||
oasis-cloud
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个变动的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
☑️ 请求合并前的自查清单