Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rate): 新增 touchable 属性支持滑动选择 #1880

Merged
merged 7 commits into from
Jan 25, 2024

Conversation

eiinu
Copy link
Member

@eiinu eiinu commented Jan 19, 2024

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • fork仓库代码是否为最新避免文件冲突
  • Files changed 没有 package.json lock 等无关文件

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (20ae2cd) 76.21% compared to head (98db4dc) 76.23%.
Report is 6 commits behind head on next.

Files Patch % Lines
src/packages/rate/rate.tsx 78.94% 10 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1880      +/-   ##
==========================================
+ Coverage   76.21%   76.23%   +0.01%     
==========================================
  Files         215      215              
  Lines        8700     8756      +56     
  Branches     2490     2507      +17     
==========================================
+ Hits         6631     6675      +44     
- Misses       1873     1883      +10     
- Partials      196      198       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiaoyatong
Copy link
Collaborator

1、可滑动区域是不是稍微放大一下
2、自定义颜色的时候,不生效
3、可以支持绑定事件的触发

@eiinu
Copy link
Member Author

eiinu commented Jan 24, 2024

1、可滑动区域是不是稍微放大一下 2、自定义颜色的时候,不生效 3、可以支持绑定事件的触发

已修改

onChange: (value: number) => void
onTouchStart: (e: TouchEvent) => void
onTouchMove: (e: TouchEvent, value: number) => void
onTouchEnd: (e: TouchEvent, value: number) => void
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以考虑下只加 touchend 事件,touchStart 和 touchmove 应用场景的频率需要考虑

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已删除 touchStart & touchMove

@xiaoyatong xiaoyatong merged commit 293d335 into jdf2e:next Jan 25, 2024
5 checks passed
@xiaoyatong xiaoyatong added the wonderful Wonderful solutions label Jan 26, 2024
@oasis-cloud oasis-cloud linked an issue Jan 26, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL wonderful Wonderful solutions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR]: Rate组件
3 participants