-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rate): 新增 touchable 属性支持滑动选择 #1880
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## next #1880 +/- ##
==========================================
+ Coverage 76.21% 76.23% +0.01%
==========================================
Files 215 215
Lines 8700 8756 +56
Branches 2490 2507 +17
==========================================
+ Hits 6631 6675 +44
- Misses 1873 1883 +10
- Partials 196 198 +2 ☔ View full report in Codecov by Sentry. |
1、可滑动区域是不是稍微放大一下 |
已修改 |
onChange: (value: number) => void | ||
onTouchStart: (e: TouchEvent) => void | ||
onTouchMove: (e: TouchEvent, value: number) => void | ||
onTouchEnd: (e: TouchEvent, value: number) => void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以考虑下只加 touchend 事件,touchStart 和 touchmove 应用场景的频率需要考虑
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已删除 touchStart & touchMove
🤔 这个变动的性质是?
🔗 相关 Issue
💡 需求背景和解决方案
☑️ 请求合并前的自查清单