docs(configprovider): 文档可读性优化 #1882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #1882 +/- ##
==========================================
+ Coverage 76.06% 76.21% +0.15%
==========================================
Files 215 215
Lines 8699 8700 +1
Branches 2489 2490 +1
==========================================
+ Hits 6617 6631 +14
+ Misses 1886 1873 -13
Partials 196 196 ☔ View full report in Codecov by Sentry. |
oasis-cloud
requested changes
Jan 19, 2024
…x12321/nutui-react into hxy/0119/configProvider-fix
oasis-cloud
requested changes
Jan 23, 2024
src/packages/configprovider/doc.md
Outdated
| @@ -36,34 +36,99 @@ NutUI-React 可以通过 [CSS 变量](https://developer.mozilla.org/zh-CN/docs/W | |||
| ConfigProvider 组件提供了覆盖 CSS 变量的能力，你需要在根节点包裹一个 ConfigProvider 组件，并通过 theme 属性来配置一些主题变量。 | |||
|
|
|||
| > ConfigProvider 组件不是一个虚拟组件，它会生成一个 div 标签。 | |||
| > | |||
| ##### Textarea 默认 | |||
There was a problem hiding this comment.
configprovider 组件更偏向说明，不必和例子对应，此组件的重点不在右侧演示的例子上。可以调整下 demo 的顺序，因为文档先讲了 主题定制，然后才是国际化
There was a problem hiding this comment.
明白，doc和demo重新调整了下
oasis-cloud
changed the title
Alex-huxiyang
changed the title
Alex-huxiyang
changed the title
oasis-cloud
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
文档优化、doc&demo一致化、button demo错字修改
🤔 这个变动的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
☑️ 请求合并前的自查清单