Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(swiper): 轮播跳帧 #1886

Merged
merged 6 commits into from
Jan 23, 2024
Merged

fix(swiper): 轮播跳帧 #1886

merged 6 commits into from
Jan 23, 2024

Conversation

oasis-cloud
Copy link
Collaborator

@oasis-cloud oasis-cloud commented Jan 22, 2024

🤔 这个变动的性质是?

  • 日常 bug 修复

🔗 相关 Issue

1.swiper 自动轮播在一轮结束后,第二轮轮播到第二帧出现跳帧

2.使用 countdown 和 swiper,swiper 无法自动轮播,因为组件中的状态变更,会重新渲染,由于 swiper 监听 children 变化,导致状态取消了自动轮播

💡 需求背景和解决方案

针对第二个问题,需要去掉对 children,并调整了相关的 demo,动态加载和异步加载可以借鉴异步加载的方式处理。

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3c808fa) 76.06% compared to head (3d313b4) 76.21%.

Files Patch % Lines
src/packages/swiper/swiper.tsx 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1886      +/-   ##
==========================================
+ Coverage   76.06%   76.21%   +0.15%     
==========================================
  Files         215      215              
  Lines        8699     8700       +1     
  Branches     2489     2490       +1     
==========================================
+ Hits         6617     6631      +14     
+ Misses       1886     1873      -13     
  Partials      196      196              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oasis-cloud oasis-cloud changed the title fix: 轮播跳帧 fix(swiper): 轮播跳帧 Jan 22, 2024
@xiaoyatong xiaoyatong merged commit 6ff2dc8 into jdf2e:next Jan 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants