Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(image): 文档可读性优化 #1887

Merged
merged 5 commits into from
Jan 25, 2024

Conversation

Alex-huxiyang
Copy link
Collaborator

@Alex-huxiyang Alex-huxiyang commented Jan 22, 2024

统一与调整demo&doc、统一代码风格

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • fork仓库代码是否为最新避免文件冲突
  • Files changed 没有 package.json lock 等无关文件

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3c808fa) 76.06% compared to head (b2212a8) 76.21%.
Report is 9 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1887      +/-   ##
==========================================
+ Coverage   76.06%   76.21%   +0.15%     
==========================================
  Files         215      215              
  Lines        8699     8700       +1     
  Branches     2489     2490       +1     
==========================================
+ Hits         6617     6631      +14     
+ Misses       1886     1873      -13     
  Partials      196      196              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/packages/image/doc.taro.md Show resolved Hide resolved
src/packages/image/doc.taro.md Outdated Show resolved Hide resolved
| none | 保持图片原有尺寸 |
| scale-down | 取 none 或 contain 中较小的一个 |

### ImagePosition 图片位置
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

新增加的这些属性,需要再 taro 文档中确认是否存在,以及取值是什么

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这些属性在taro不存在。已删除

@Alex-huxiyang Alex-huxiyang changed the title fix(image): 统一与调整demo&doc、统一代码风格 fix(image): 文档可读性优化 Jan 24, 2024
@oasis-cloud oasis-cloud merged commit 2a605c6 into jdf2e:next Jan 25, 2024
5 checks passed
@Alex-huxiyang Alex-huxiyang deleted the hxy/01222/img-fix branch March 13, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants