feat(navbar): title区域自适应宽度 #1891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## next #1891 +/- ##
==========================================
+ Coverage 76.21% 76.25% +0.03%
==========================================
Files 215 215
Lines 8700 8733 +33
Branches 2490 2500 +10
==========================================
+ Hits 6631 6659 +28
- Misses 1873 1878 +5
Partials 196 196 ☔ View full report in Codecov by Sentry. |
oasis-cloud
requested changes
Jan 23, 2024
src/packages/navbar/navbar.tsx
Outdated
| className={`${classPrefix}-title`} | ||
| style={{ | ||
| minWidth: contentRealWidth, | ||
| maxWidth: contentRealWidth, |
There was a problem hiding this comment.
值都是同一个，为什么要分别设置 min、max，只设置 width 会有异常吗？
There was a problem hiding this comment.
值都是同一个，为什么要分别设置 min、max，只设置 width 会有异常吗？
设置 min 是为了限制样式中兜底的min，设置 max 是为了flex布局，right区域是定位不占位问题
title居左布局，title宽度改成样式实现，已提交
| } else if (leftRectWidth && rightRectWidth) { | ||
| centerWidth = | ||
| wrapperWidth - | ||
| (leftRectWidth > rightRectWidth |
There was a problem hiding this comment.
这里的算法是考虑到什么情况了？
left、right内容区域不同宽， title区域居中
xiaoyatong
reviewed
Jan 24, 2024
src/packages/navbar/navbar.scss
Outdated
| @@ -39,6 +39,9 @@ | |||
| font-size: $navbar-title-font-size; | |||
| font-weight: $navbar-title-font-weight; | |||
| color: $navbar-title-font-color; | |||
| & > div { | |||
There was a problem hiding this comment.
如果是 rn 或者鸿蒙系统，可能无法匹配div
There was a problem hiding this comment.
如果是 rn 或者鸿蒙系统，可能无法匹配div
改为demo中实现
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个变动的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
☑️ 请求合并前的自查清单