Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(grid): 文档可读性优化 #1903

Merged
merged 6 commits into from
Jan 25, 2024

Conversation

Alex-huxiyang
Copy link
Collaborator

@Alex-huxiyang Alex-huxiyang commented Jan 24, 2024

doc、demo统一,部分代码风格调整

🤔 这个变动的性质是?

  • 站点、文档改进
  • 演示代码改进
  • 国际化改进

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • fork仓库代码是否为最新避免文件冲突
  • Files changed 没有 package.json lock 等无关文件

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1109172) 76.21% compared to head (75749df) 76.26%.
Report is 7 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1903      +/-   ##
==========================================
+ Coverage   76.21%   76.26%   +0.04%     
==========================================
  Files         215      215              
  Lines        8700     8760      +60     
  Branches     2490     2512      +22     
==========================================
+ Hits         6631     6681      +50     
- Misses       1873     1881       +8     
- Partials      196      198       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oasis-cloud oasis-cloud changed the title fix(grid): doc、demo统一、部分代码风格调整 fix(grid): doc、demo统一,部分代码风格调整 Jan 24, 2024
@Alex-huxiyang Alex-huxiyang changed the title fix(grid): doc、demo统一,部分代码风格调整 docs(grid): 文档可读性优化 Jan 24, 2024
@@ -62,9 +62,10 @@ const GridDemo = () => {
})

const onClick = (item: any, index: number) => {
Taro.showToast({ title: `点击了${item.text},第${index}` })
Taro.showToast({ title: `clicked ${item.text}, index ${index}` })
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么改成英文了?

@oasis-cloud oasis-cloud merged commit 4e82bcf into jdf2e:next Jan 25, 2024
5 checks passed
@Alex-huxiyang Alex-huxiyang deleted the hxy/0124/grid-fix branch March 13, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants