-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(grid): 文档可读性优化 #1903
Merged
Merged
docs(grid): 文档可读性优化 #1903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #1903 +/- ##
==========================================
+ Coverage 76.21% 76.26% +0.04%
==========================================
Files 215 215
Lines 8700 8760 +60
Branches 2490 2512 +22
==========================================
+ Hits 6631 6681 +50
- Misses 1873 1881 +8
- Partials 196 198 +2 ☔ View full report in Codecov by Sentry. |
oasis-cloud
requested changes
Jan 25, 2024
src/packages/grid/demo.taro.tsx
Outdated
@@ -62,9 +62,10 @@ const GridDemo = () => { | |||
}) | |||
|
|||
const onClick = (item: any, index: number) => { | |||
Taro.showToast({ title: `点击了${item.text},第${index}个` }) | |||
Taro.showToast({ title: `clicked ${item.text}, index ${index}` }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
为什么改成英文了?
oasis-cloud
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc、demo统一,部分代码风格调整
🤔 这个变动的性质是?
🔗 相关 Issue
💡 需求背景和解决方案
☑️ 请求合并前的自查清单