fix(input): controlled mode, content clearing does not work #1912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue is not possible
oasis-cloud
changed the title
xiaoyatong
reviewed
Jan 31, 2024
| @@ -167,22 +167,18 @@ export const Input = forwardRef( | |||
| forceUpdate() | |||
| } | |||
|
|
|||
| const handleFocus = (event: Event) => { | |||
There was a problem hiding this comment.
这个改动，也可以用在 input.tsx 上。
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #1912 +/- ##
==========================================
+ Coverage 76.30% 76.56% +0.26%
==========================================
Files 215 215
Lines 8794 8791 -3
Branches 2522 2521 -1
==========================================
+ Hits 6710 6731 +21
+ Misses 1886 1863 -23
+ Partials 198 197 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个变动的性质是？
🔗 相关 Issue
#1876
💡 需求背景和解决方案
通过 setState设置 value 为空，在移动设备上会先出触发按钮的 click 事件，然后才能触发 blur 事件，在 click 事件触发，并不能更新 blur 事件使用的值，所以需要将 blur 和 focus 改为使用 value 这个状态。