Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(form): correct form methods usage of demo #2528

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

Alex-huxiyang
Copy link
Collaborator

@Alex-huxiyang Alex-huxiyang commented Aug 6, 2024

  • 站点、文档改进
  • 演示代码改进

Summary by CodeRabbit

  • 新功能

    • 在表单界面中新增提交按钮,改善用户交互体验。
    • 重新构建“字段D”的表单项,增加验证规则,确保用户输入有效数据。
  • 改进

    • 优化表单逻辑结构,增强用户体验。

Copy link

coderabbitai bot commented Aug 6, 2024

Walkthrough

此次更改增强了Demo3组件的功能,主要通过在表单底部添加一个提交按钮和优化表单项的处理。新按钮使用户能够更方便地提交数据,同时对“字段D”的重新结构化提高了表单的可读性和输入验证。这些改动旨在提升用户体验,确保数据的完整性和逻辑性。

Changes

文件路径 更改摘要
src/packages/form/demos/.../demo3.tsx 1. 在表单底部添加了提交按钮,改善了用户交互。
2. 对“字段D”进行了重构,添加了标签和验证规则,确保输入的有效性。

Poem

🐇 在表单中跳跃,按钮闪亮,
数据输入,乐趣无量。
字段D的新装,清晰辉煌,
用户体验更佳,快乐无疆! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.17%. Comparing base (2993e06) to head (659f749).

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2528   +/-   ##
=======================================
  Coverage   83.17%   83.17%           
=======================================
  Files         217      217           
  Lines       17799    17799           
  Branches     2570     2570           
=======================================
  Hits        14805    14805           
  Misses       2989     2989           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Alex-huxiyang Alex-huxiyang linked an issue Aug 6, 2024 that may be closed by this pull request
@160905
Copy link

160905 commented Aug 7, 2024

可以在这里回复一下你的 核心code吗

@Alex-huxiyang
Copy link
Collaborator Author

Alex-huxiyang commented Aug 8, 2024

可以在这里回复一下你的 核心code吗

const Demo3 = () => {
  return (
    <>
      <Form
        divider
        labelPosition="right"
        footer={
          <>
            <Button nativeType="submit" block type="primary">
              提交
            </Button>
          </>
        }
      >
        <Form.Item label="字段A" name="username" rules={[{ required: true }]}>
          <Input placeholder="请输入字段A" type="text" />
        </Form.Item>
        <Form.Item shouldUpdate noStyle>
          {({ getFieldValue }: FormInstance) => {
            const value = getFieldValue('username')
            if (!value) return null
            return (
              <Form.Item label="字段D" name="age" rules={[{ required: true }]}>
                <TextArea placeholder="字段D" maxLength={100} />
              </Form.Item>
            )
          }}
        </Form.Item>
      </Form>
    </>
  )
}

@Alex-huxiyang Alex-huxiyang merged commit 663c161 into jdf2e:next Aug 8, 2024
5 checks passed
@160905
Copy link

160905 commented Aug 9, 2024

原来是 Form.Item 嵌套 Form.Item

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form 关联显示后提交表单不触发校验
2 participants