Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(range): usememo #2638

Merged
merged 5 commits into from
Oct 12, 2024
Merged

fix(range): usememo #2638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3f4d428
fix: range refactor
xiaoyatong Oct 11, 2024
3a9f29e
fix(range): usememo
xiaoyatong Oct 11, 2024
d993c39
fix: conflict fixed
xiaoyatong Oct 11, 2024
2a60c3b
fix: 修订scope
xiaoyatong Oct 11, 2024
affec60
fix: test
xiaoyatong Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions src/packages/range/__test__/__snapshots__/range.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,55 @@ exports[`range props test 1`] = `
</div>
`;

exports[`range props test 2`] = `
<div>
<div
class="nut-range-container test-range"
>
<div
class="min"
>
0
</div>
<div
class="nut-range"
>
<div
class="nut-range-bar"
style="width: 40%; left: 0%; transition: none;"
>
<div
class="nut-range-button-wrapper"
>
<div
class="nut-range-button"
>
<div
class="number"
>
40
</div>
</div>
</div>
</div>
</div>
<div
class="max"
>
100
</div>
</div>
</div>
`;

exports[`range test 1`] = `
"<div><div class="nut-range-container"><div class="min">0</div><div class="nut-range"><div class="nut-range-bar" style="width: 30%; left: 30%; transition: none;"><div class="nut-range-button-wrapper-left
"><div class="nut-range-button"><div class="number">30</div></div></div><div class="
nut-range-button-wrapper-right"><div class="nut-range-button"><div class="number">60</div></div></div></div></div><div class="max">100</div></div></div>"
`;

exports[`range test 2`] = `
"<div><div class="nut-range-container"><div class="min">0</div><div class="nut-range"><div class="nut-range-bar" style="width: 30%; left: 30%; transition: none;"><div class="nut-range-button-wrapper-left
"><div class="nut-range-button"><div class="number">30</div></div></div><div class="
nut-range-button-wrapper-right"><div class="nut-range-button"><div class="number">60</div></div></div></div></div><div class="max">100</div></div></div>"
`;
60 changes: 59 additions & 1 deletion src/packages/range/__test__/range.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import * as React from 'react'
import '@testing-library/jest-dom'
import { render } from '@testing-library/react'
import { render, fireEvent } from '@testing-library/react'
import Range from '@/packages/range'

test('range props test', () => {
Expand Down Expand Up @@ -160,3 +160,61 @@ test('desc test', () => {
expect(container.querySelector('.max')?.innerHTML).toBe(state.maxDescription)
expect(container.querySelector('.number')?.innerHTML).toBe('40%')
})

test('range click test', () => {
const { container } = render(
<Range defaultValue={40} style={{ color: 'red' }} />
)

if (container.querySelector('.nut-range-bar')) {
fireEvent.click(container.querySelector('.nut-range-bar') as HTMLElement)
}
})

test('range click test', () => {
const state = {
value0: [30, 60],
}
const { container } = render(<Range range defaultValue={state.value0} />)
if (container.querySelector('.nut-range-bar')) {
fireEvent.click(container.querySelector('.nut-range-bar') as HTMLElement)
}
})
Comment on lines +174 to +182
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

重复的测试名称和缺少断言

  1. 这个测试用例与前一个同名，可能会导致混淆。建议使用更具描述性的名称，如 'range click test in range mode'。

  2. 同样，这个测试也缺少断言来验证点击后的行为。建议添加断言来检查点击后的状态变化。

示例改进：

test('range click test in range mode', () => {
  const initialValue = [30, 60]
  const { container } = render(<Range range defaultValue={initialValue} />)
  
  const rangeBar = container.querySelector('.nut-range-bar') as HTMLElement
  if (rangeBar) {
    fireEvent.click(rangeBar)
    // 添加断言，例如：
    // const newValue = container.querySelectorAll('.number')
    // expect(newValue[0].innerHTML).not.toBe(initialValue[0].toString())
    // expect(newValue[1].innerHTML).not.toBe(initialValue[1].toString())
  }
})


test('range click disable test', () => {
const { container } = render(
<Range defaultValue={40} disabled style={{ color: 'red' }} />
)

if (container.querySelector('.nut-range-bar')) {
fireEvent.click(container.querySelector('.nut-range-bar') as HTMLElement)
}
})

test('range click vertical test', () => {
const { container } = render(
<Range defaultValue={40} vertical style={{ color: 'red' }} />
)

if (container.querySelector('.nut-range-bar')) {
fireEvent.click(container.querySelector('.nut-range-bar') as HTMLElement)
}
})

test('range touch test', () => {
const { container } = render(<Range defaultValue={40} />)

const track = container.querySelector('.nut-range-button')
const button = container.querySelector('.number')

if (track) {
fireEvent.touchStart(track, {
touches: [{ clientX: 0 }],
})
fireEvent.touchMove(track, {
touches: [{ clientX: 10 }],
})
fireEvent.touchEnd(track)
expect(button?.innerHTML).toBe('100')
}
})
4 changes: 2 additions & 2 deletions src/packages/range/demos/h5/demo5.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ const Demo5 = () => {
return (
<Cell style={cellStyle}>
<Range
defaultValue={0}
max={10}
defaultValue={-8}
max={-6}
min={-10}
onEnd={(val) => Toast.show(`${val}`)}
/>
Expand Down
2 changes: 2 additions & 0 deletions src/packages/range/range.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@
position: relative;
width: 100%;
height: 100%;
max-width: 100%;
max-height: 100%;
background: $range-active-color;
border-radius: inherit;
transition: all 0.2s;
Expand Down
Loading
Loading