Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(infiniteloading): remove deprecated usage #2801

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

Alex-huxiyang
Copy link
Collaborator

@Alex-huxiyang Alex-huxiyang commented Nov 27, 2024

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • fork仓库代码是否为最新避免文件冲突
  • Files changed 没有 package.json lock 等无关文件

Summary by CodeRabbit

  • 新特性
    • 更新了InfiniteLoading组件的文档,新增了CSS变量--nutui-infiniteloading-icon-size,允许用户自定义加载图标的大小,默认值为24px
    • 更新了现有CSS变量--nutui-infiniteloading-color的描述,明确其为底部文本颜色。

Copy link

coderabbitai bot commented Nov 27, 2024

Walkthrough

此次更改涉及对InfiniteLoading组件的文档进行更新,新增了一个CSS变量--nutui-infiniteloading-icon-size,用于自定义加载图标的大小,默认值为24px。该变量在多个语言版本的文档中进行了添加,包括英文、中文和Taro版本。同时,现有的CSS变量--nutui-infiniteloading-color的描述也得到了澄清,以更准确地反映其功能。

Changes

文件路径 更改摘要
src/packages/infiniteloading/doc.en-US.md 新增CSS变量--nutui-infiniteloading-icon-size,默认值24px
src/packages/infiniteloading/doc.md 新增CSS变量--nutui-infiniteloading-icon-size,并澄清现有变量--nutui-infiniteloading-color的描述。
src/packages/infiniteloading/doc.taro.md 新增CSS变量--nutui-infiniteloading-icon-size,默认值24px,并澄清现有变量--nutui-infiniteloading-color的描述。
src/packages/infiniteloading/doc.zh-TW.md 新增CSS变量--nutui-infiniteloading-icon-size,默认值24px,并澄清现有变量--nutui-infiniteloading-color的描述。

Possibly related PRs

Suggested labels

3.x

Suggested reviewers

  • oasis-cloud

Poem

在兔子的视野中,
加载图标更灵动,
新变量如春风,
文档更新真欢喜,
让用户更自如,
体验加载的乐趣。 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 3fb4d5f and 026fdac.

📒 Files selected for processing (4)
  • src/packages/infiniteloading/doc.en-US.md (0 hunks)
  • src/packages/infiniteloading/doc.md (0 hunks)
  • src/packages/infiniteloading/doc.taro.md (0 hunks)
  • src/packages/infiniteloading/doc.zh-TW.md (0 hunks)
💤 Files with no reviewable changes (4)
  • src/packages/infiniteloading/doc.en-US.md
  • src/packages/infiniteloading/doc.md
  • src/packages/infiniteloading/doc.taro.md
  • src/packages/infiniteloading/doc.zh-TW.md

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the 2.x Target branch 2.x label Nov 27, 2024
@Alex-huxiyang Alex-huxiyang linked an issue Nov 27, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.04%. Comparing base (3fb4d5f) to head (026fdac).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2801      +/-   ##
==========================================
- Coverage   84.07%   84.04%   -0.04%     
==========================================
  Files         217      217              
  Lines       17830    17830              
  Branches     2609     2606       -3     
==========================================
- Hits        14991    14985       -6     
- Misses       2834     2840       +6     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oasis-cloud oasis-cloud merged commit 543ec6d into jdf2e:next Nov 28, 2024
5 of 6 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Dec 17, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Target branch 2.x size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InfiniteLoading文档说明错误
2 participants