Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(empty): correct css margin and docs #2819

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

Alex-huxiyang
Copy link
Collaborator

@Alex-huxiyang Alex-huxiyang commented Dec 3, 2024

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • fork仓库代码是否为最新避免文件冲突
  • Files changed 没有 package.json lock 等无关文件

Summary by CodeRabbit

  • 新特性

    • 更新了 Empty 组件的文档,增加了使用示例和属性说明,提升了文档的清晰度和可用性。
    • 新增了 actions 属性,支持自定义操作。
    • 增加了 CSS 变量以增强主题定制能力。
  • 文档

    • 详细描述了 Empty 组件的使用方法、属性及其默认值。
    • 增强了多个示例展示,涵盖基本用法、尺寸变化和自定义内容。
  • 样式

    • 调整了 Empty 组件中操作容器的边距,优化了组件的外观。

Copy link

coderabbitai bot commented Dec 3, 2024

Walkthrough

本次变更主要针对 Empty 组件的文档进行了更新,涉及多个语言版本的文档,包括英文、中文(简体和繁体)和 Taro 版本。更新内容包括新增和修改属性描述、示例、主题定制部分以及 CSS 变量的定义,旨在提供更全面的使用指导和自定义选项。此外,还对样式文件进行了调整,修改了某些边距属性,以改善组件的外观和布局。

Changes

文件路径 变更摘要
src/packages/empty/doc.en-US.md 更新了 Empty 组件文档,增加了多个示例和属性描述,包括 image, imageSize, title, description, size, status, actions。新增主题定制部分和 CSS 变量。
src/packages/empty/doc.md 在文档中新增 actions 属性,类型为 Array,默认值为 [];更新了主题定制部分,新增 CSS 变量 --nutui-empty-description-margin-top
src/packages/empty/doc.taro.md 扩展了属性表,详细描述了每个属性;更新了主题定制部分,新增 CSS 变量 --nutui-empty-description-margin-top
src/packages/empty/doc.zh-TW.md 增加了多个使用示例和属性描述,详细列出了属性及其类型和默认值,更新了主题定制部分。
src/packages/empty/empty.scss 修改了 .nut-empty 类中动作容器的边距,&-actions-basemargin-top16px 增加到 24px&-actions-smallmargin-top24px 减少到 16px
src/styles/variables.scss 更新了多个颜色和样式变量,新增了多个 UI 组件的变量,移除了与空描述相关的变量。

Possibly related PRs

Suggested labels

size/XS, 2.x

Suggested reviewers

  • oasis-cloud

兔子欢跃在草地,
文档更新真是美。
属性示例齐上阵,
自定义样式任君选。
让我们一起跳跃吧,
享受这份新变化! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 116fbbf and b62dd44.

📒 Files selected for processing (6)
  • src/packages/empty/doc.en-US.md (0 hunks)
  • src/packages/empty/doc.md (0 hunks)
  • src/packages/empty/doc.taro.md (0 hunks)
  • src/packages/empty/doc.zh-TW.md (0 hunks)
  • src/packages/empty/empty.scss (1 hunks)
  • src/styles/variables.scss (0 hunks)
💤 Files with no reviewable changes (5)
  • src/packages/empty/doc.md
  • src/packages/empty/doc.zh-TW.md
  • src/packages/empty/doc.en-US.md
  • src/packages/empty/doc.taro.md
  • src/styles/variables.scss
🔇 Additional comments (2)
src/packages/empty/empty.scss (2)

50-50: 基础尺寸动作区域间距调整合理!

增加到 24px 的上边距能为基础尺寸版本提供更好的视觉层次感和空间布局。


55-55: 小尺寸动作区域间距调整得当!

减小到 16px 的上边距与小尺寸版本的整体比例更加协调,维持了良好的视觉平衡。


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the 3.x Target branch 3.x label Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.98%. Comparing base (116fbbf) to head (b62dd44).
Report is 1 commits behind head on feat_v3.x.

Additional details and impacted files
@@            Coverage Diff             @@
##           feat_v3.x    #2819   +/-   ##
==========================================
  Coverage      83.98%   83.98%           
==========================================
  Files            220      220           
  Lines          17882    17882           
  Branches        2676     2676           
==========================================
  Hits           15019    15019           
  Misses          2858     2858           
  Partials           5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Target branch 3.x size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants