fix: dark 模式下arrow 未配置 #2850

xiaoyatong · 2024-12-10T13:03:47Z

🤔 这个变动的性质是？

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

文档已补充或无须补充
代码演示已提供或无须提供
TypeScript 定义已补充或无须补充
fork仓库代码是否为最新避免文件冲突
Files changed 没有 package.json lock 等无关文件

Summary by CodeRabbit

新特性
- 改进了暗模式下的弹出框组件样式，增加了箭头元素的边框颜色。
- 更新了弹出框内容的背景和文本颜色，确保样式优先级。
- 调整了弹出框菜单项的悬停状态，以提高可读性。
- 保持并调整了右到左（RTL）布局的样式，确保内容和菜单项的正确对齐和间距。

coderabbitai · 2024-12-10T13:03:55Z

Walkthrough

本次更改主要集中在 popover.scss 文件中，对 .nut-popover 组件及其相关元素的样式进行了修改。主要更新包括为 .nut-popover-dark 类中的箭头元素添加了特定的边框颜色属性，并确保这些样式在深色模式下的一致性。此外，还对 .nut-popover-content 类进行了更新，以强制背景和文本颜色的优先级，并修改了 .nut-popover-menu-item 的悬停状态，以提高可读性。RTL（从右到左）样式也得到了保留和调整。

Changes

文件路径	更改摘要
src/packages/popover/popover.scss	修改了 `.nut-popover` 组件的样式，添加了箭头元素的边框颜色属性，更新了背景和文本颜色的优先级，调整了 RTL 样式。

Possibly related PRs

refactor: resolve sass nested rules warning #2579: 此 PR 修改了 src/packages/popover/popover.scss 文件，直接与主 PR 中的相同文件相关，专注于弹出组件的 CSS 规则。
fix: 修改tag和badge字体样式变量 #2681: 此 PR 更新了 src/styles/variables.scss 文件，其中包括可能影响 .nut-popover 样式的一些样式变量的更改，表明在样式一致性方面的潜在关系。
fix: jd white screen #2824: 此 PR 涉及对 src/styles/theme-dark.scss 的更改，可能与主 PR 中提到的 .nut-popover-dark 类的深色模式样式增强有关。

Suggested labels

2.x

Suggested reviewers

oasis-cloud

在黑暗中，兔子跳，
弹出窗，样式好。
边框色，箭头亮，
轻松阅读，心欢畅。
RTL 也不怕，调整好，
兔子欢呼，真妙妙！ 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2024-12-10T13:05:33Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.01%. Comparing base (601b5d1) to head (9110660).
Report is 1 commits behind head on next.

Additional details and impacted files

@@           Coverage Diff           @@
##             next    #2850   +/-   ##
=======================================
  Coverage   84.01%   84.01%           
=======================================
  Files         219      219           
  Lines       17899    17899           
  Branches     2622     2622           
=======================================
  Hits        15038    15038           
  Misses       2856     2856           
  Partials        5        5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

coderabbitai

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

src/packages/popover/popover.scss (1)
Line range hint 242-252: 建议：考虑优化深色模式样式的优先级处理

当前实现使用了 !important 来强制应用背景色和文本颜色。虽然目前可以正常工作，但建议考虑以下优化方案：

通过提高选择器优先级来避免使用 !important

使用 CSS 自定义属性（CSS变量）来统一管理主题颜色

这样可以提高代码的可维护性和灵活性。
.nut-popover-dark {
  .nut-popover-content {
-   background: $popover-text-color !important;
-   color: $popover-content-background-color !important;
+   &.nut-popover-content {
+     background: $popover-text-color;
+     color: $popover-content-background-color;
+   }
  }
}

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 601b5d1 and 9110660.

📒 Files selected for processing (1)

src/packages/popover/popover.scss (1 hunks)

🔇 Additional comments (1)

src/packages/popover/popover.scss (1)

230-241: 箭头边框颜色配置正确

在深色模式下，箭头边框颜色现已正确设置为 $popover-text-color，与深色主题保持一致。这个修复确保了所有方向（上、下、左、右）的箭头都能在深色模式下正确显示。

fix: dark 模式下arrow 未配置

9110660

pull-request-size bot added the size/S label Dec 10, 2024

github-actions bot added the 2.x label Dec 10, 2024

xiaoyatong requested a review from Alex-huxiyang December 10, 2024 13:04

coderabbitai bot reviewed Dec 10, 2024

View reviewed changes

oasis-cloud approved these changes Dec 10, 2024

View reviewed changes

Alex-huxiyang approved these changes Dec 11, 2024

View reviewed changes

Alex-huxiyang merged commit 49106e3 into jdf2e:next Dec 11, 2024
6 checks passed

This was referenced Dec 11, 2024

feat(popover): 增加最大宽度设置，支持文本超过最大宽度时，换行展示。 #2851

Merged

fix: 修改小程序下自动吸边计算逻辑&&解决部分小程序写法不支持问题 #2855

Merged

coderabbitai bot mentioned this pull request Jan 15, 2025

docs: popup 增加 taro ios 兼容 faq #2943

Merged

20 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: dark 模式下arrow 未配置 #2850

fix: dark 模式下arrow 未配置 #2850

xiaoyatong commented Dec 10, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 10, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

codecov bot commented Dec 10, 2024 •

edited

Loading

coderabbitai bot left a comment

fix: dark 模式下arrow 未配置 #2850

fix: dark 模式下arrow 未配置 #2850

Conversation

xiaoyatong commented Dec 10, 2024 • edited by coderabbitai bot Loading

🤔 这个变动的性质是？

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

Summary by CodeRabbit

coderabbitai bot commented Dec 10, 2024 • edited Loading

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

codecov bot commented Dec 10, 2024 • edited Loading

Codecov Report

coderabbitai bot left a comment

Choose a reason for hiding this comment

xiaoyatong commented Dec 10, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 10, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Dec 10, 2024 •

edited

Loading