Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for • symbol #10

Merged
merged 1 commit into from
Sep 19, 2022
Merged

fix for • symbol #10

merged 1 commit into from
Sep 19, 2022

Conversation

Zephyrusg
Copy link
Contributor

I experience that the function get-wgpackege fails with wingit id "putty.putty"

This happens because of the release notes that are in the winget package.
The release notes contain the • symbol what powershell replace with 'ÔÇó'

So, I added an extra replace step to change the 'ÔÇó' to another readable symbol *.

Now the regex in the convert private function takes the right lines and the convertfrom-yaml is working again.

@jdhitsolutions jdhitsolutions merged commit 04c69c0 into jdhitsolutions:main Sep 19, 2022
@jdhitsolutions
Copy link
Owner

I still get errors, so I'll keep looking at this.

@jdhitsolutions
Copy link
Owner

What culture are you running under?

@jdhitsolutions jdhitsolutions added the pending pending user feedback label Sep 19, 2022
@Zephyrusg
Copy link
Contributor Author

@jdhitsolutions I running this on a Windows 11 Dev channel on PWS 7.2.6 with culture EN-GB.

But my powershell isn't so sure about that:

Get-Culture | fl *

Parent :
LCID : 127
KeyboardLayoutId : 127
Name :
IetfLanguageTag :
DisplayName : Invariant Language (Invariant Country)
NativeName : Invariant Language (Invariant Country)
EnglishName : Invariant Language (Invariant Country)
TwoLetterISOLanguageName : iv
ThreeLetterISOLanguageName : ivl
ThreeLetterWindowsLanguageName : IVL

@jdhitsolutions
Copy link
Owner

I just published v1.6.0 to the PowerShell Gallery. Update the module and try the putty package again. It works now for me.

image

@Zephyrusg
Copy link
Contributor Author

@jdhitsolutions Thz for pushing it to the PSGallery.
It also works for me on Pws 5.1 and 7. 👍

@SebCT
Copy link

SebCT commented Sep 19, 2022

Hello!

Get-WGPackage did only work for me with these modifications in line 53-54 in the Get-WGpackage.ps1 script, because my profile path has a space:

$winget = "'" + (Get-WGPath | out-string).Trim() + "'"
$cmdText = "& "
$cmdText += "$winget show --source $source"

@SebCT
Copy link

SebCT commented Sep 19, 2022

In addition i had to modify the lines 23-24 in private.ps1 for the _convert function because of german OS/WinGet, so that putty also works, sadly the replace with '*' didn't work for the german version:

$i = $list.FindIndex({ $args[0] -match "^Versionshinweise:" })
$j = $list.FindIndex({ $args[0] -match "^Installationsprogramm:" })

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending pending user feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants