Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed "- 1" #18

Merged
merged 1 commit into from
Jan 2, 2023
Merged

Removed "- 1" #18

merged 1 commit into from
Jan 2, 2023

Conversation

Zephyrusg
Copy link
Contributor

The - 1 on line 27 removes one line to much from the list object.

I have seen this problem with the app winget ID: Zoom.zoom.

The list object before the removal of the release notes:

Version: 5.12.10137
Publisher: Zoom
Publisher Url: https://zoom.us/
Publisher Support Url: https://support.zoom.us/
Author: Zoom Video Communications, Inc.
Description: Zooms secure, reliable video platform powers all of your communication needs, including meetings, chat, phone, webinars, and online events.
Homepage: https://zoom.us/
License: Proprietary
License Url: https://explore.zoom.us/en/terms/
Privacy Url: https://explore.zoom.us/en/privacy/
Copyright: Copyright 2012-2022 Zoom Video Communications, Inc. All rights reserved.
Release Notes: Resolved Issues
**Documentation:
  Learning Center: https://learning.zoom.us/learn**
Installer:
  Type: exe
  Download Url: https://cdn.zoom.us/prod/5.12.6.10137/x64/ZoomInstallerFull.exe
  SHA256: f84b60a1ee9b8702ded74833dfffa3745d1122ba6110e1b98f1b66e91ae1d2e7
  Release Date: 2022-11-07

The list object after the removal of the release notes:

Version: 5.12.10137
Publisher: Zoom
Publisher Url: https://zoom.us/
Publisher Support Url: https://support.zoom.us/
Author: Zoom Video Communications, Inc.
Description: Zooms secure, reliable video platform powers all of your communication needs, including meetings, chat, phone, webinars, and online events.
Homepage: https://zoom.us/
License: Proprietary
License Url: https://explore.zoom.us/en/terms/
Privacy Url: https://explore.zoom.us/en/privacy/
Copyright: Copyright 2012-2022 Zoom Video Communications, Inc. All rights reserved.
  **Learning Center: https://learning.zoom.us/learn**
Installer:
  Type: exe
  Download Url: https://cdn.zoom.us/prod/5.12.6.10137/x64/ZoomInstallerFull.exe
  SHA256: f84b60a1ee9b8702ded74833dfffa3745d1122ba6110e1b98f1b66e91ae1d2e7
  Release Date: 2022-11-07

I marked the issue with **.
The script now also removes the Documentation key.
This breaks the convert from yml.

Tested with a lot of other apps and it seeme that the removal of the extra line just removes some other crap info next to release notes.

But for zoom.zoom it breaks the convertion.

@Zephyrusg
Copy link
Contributor Author

@jdhitsolutions Can you please look at this?

Thanks

@Zephyrusg
Copy link
Contributor Author

@jdhitsolutions @djust270

All the best wishes for 2023.

Can you guys look this Bug?
It is still bugging our process.

@jdhitsolutions
Copy link
Owner

I am trying to defer work on this module while the winget team works on their PowerShell module, but I'll go ahead and merge this for now.

@jdhitsolutions jdhitsolutions merged commit 4dbda76 into jdhitsolutions:main Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants