fix: improve hook-env #3466
Merged
fix: improve hook-env #3466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdx
commented
Dec 11, 2024
| @@ -114,7 +114,7 @@ fn have_mise_env_vars_been_modified(watches: &HookEnvWatches) -> bool { | |||
|
|
|||
| #[derive(Debug, Default, Serialize, Deserialize)] | |||
| pub struct HookEnvWatches { | |||
| latest_update: u64, | |||
| latest_update: u128, | |||
There was a problem hiding this comment.
my understanding is this shouldn't work because we serialize to messagepack which doesn't have bigint... but it makes the test pass so ¯\_(ツ)_/¯
jdx
force-pushed
the
activate
branch
2 times, most recently
from
7ad6a2b to
d938aea
Compare
* check config filetime modification in millis so scripts work better * only warn if files are untrusted
This was referenced Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--no-hook-envflag for activate for debugging