Add Expr.ExponentiateOutputs and unit tests #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffmay
commented
Nov 15, 2021
| case num: Double if num.isNaN => | ||
| result.output.value match { | ||
| case obs: Double => | ||
| assert(obs.isNaN, "Expected output to be NaN") |
There was a problem hiding this comment.
NaN is pretty much the only value that isn't equal to itself, so I feel like a special case is warranted here. How this would play out in plain Scala code would be effectively the same as the result you would get from vapors, so handling NaN in the resulting output is still the responsibility of the library user.
darmbrus
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.