Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with gem-based themes in safe mode #95

Closed
benbalter opened this issue Sep 20, 2019 · 1 comment · Fixed by #96
Closed

Incompatible with gem-based themes in safe mode #95

benbalter opened this issue Sep 20, 2019 · 1 comment · Fixed by #96

Comments

@benbalter
Copy link

Because the plugin sanitizes all load paths relative to the site source, gem-based themes cannot use sass in safe mode.

Steps to reproduce:

  1. Create (or use an existing) theme that relies on sass
  2. Require the theme in you confirm
  3. Build the site in safe mode

Expected:

Theme's sass load path outside the site root is included as a load path and build succeeds with sass converted to CSS

Actual:

Build failed due to missing includes.

/cc benbalter/jekyll-remote-theme#58

@ashmaroli
Copy link
Member

Thank you for reporting this @benbalter. I've submitted a PR for review 👆

@jekyll jekyll locked and limited conversation to collaborators Sep 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants