Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append theme's sass path after all sanitizations #96

Merged

Conversation

ashmaroli
Copy link
Member

Since the theme's sass-path is always outside the source directory.

Resolves #95

@ashmaroli ashmaroli requested a review from a team September 20, 2019 17:45
@parkr
Copy link
Member

parkr commented Sep 20, 2019

Can we please add a test for this? 😄

@ashmaroli
Copy link
Member Author

This drops testing with Jekyll 3.x on Travis because 3.x is not compatible with sass-converter-2.0 in parallel with a theme since Theme#configure_sass from Jekyll 3.x calls on Sass module which is no longer loaded by this plugin.

@DirtyF
Copy link
Member

DirtyF commented Sep 26, 2019

@jekyllbot: merge +fix

@jekyllbot jekyllbot merged commit 83f6375 into jekyll:master Sep 26, 2019
jekyllbot added a commit that referenced this pull request Sep 26, 2019
@jekyll jekyll locked and limited conversation to collaborators Sep 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible with gem-based themes in safe mode
4 participants