Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display sass error in browser with livereload #160

Merged
merged 1 commit into from
Jan 1, 2024
Merged

Display sass error in browser with livereload #160

merged 1 commit into from
Jan 1, 2024

Conversation

ntkme
Copy link
Contributor

@ntkme ntkme commented Dec 29, 2023

This PR adds a new feature for live-reload where css compilation error will be displayed on the browser. Please see the demo video below on how it works for users.

This feature depends on sass-embedded >=1.69.6. In order to simplify the user experience, this PR does not bump up the required dependency version, but rather works based on feature detection. This feature is enabled automatically if sass-embedded supports it.

Demo:

jekyll-sass-converter-livereload.mp4

Copy link
Member

@mattr- mattr- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great feature! Thanks! ❤️

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit a64eb8c into jekyll:master Jan 1, 2024
7 checks passed
jekyllbot added a commit that referenced this pull request Jan 1, 2024
@ntkme ntkme deleted the livereload-css-error branch January 1, 2024 15:36
@jekyll jekyll locked and limited conversation to collaborators Dec 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants