Use display language when available

[CarlosOlivo]

In the next order:

1. User settings
2. Server settings
3. Android settings

For now, it's necessary to restart the application manually when the language is changed, as long as no events are handled.

Closes #83

[Maxr1998]

Thanks for the PR!
Apart from my review comments, could you maybe move those function to another file/class as well? Maybe even with dependency injection, scoped to the Activity. See the Koin docs for more info on that.

[Maxr1998]

Thanks for the changes! I'll review this later today (after sleeping).

EDIT: was busy with other stuff the last days, will still take some time.

[Maxr1998]

@CarlosOlivo did some more tweaks, please take another look at those and lmk if they are ok, then I'll merge.
@nielsvanvelzen would also appreciate a review from you 😁

[CarlosOlivo]

@CarlosOlivo did some more tweaks, please take another look at those and lmk if they are ok, then I'll merge.
@nielsvanvelzen would also appreciate a review from you 😁

Yep, it works fine, you just have to remove all the code that loads the locale from the API [serverSettings], I noticed after the next test that it is not necessary and even counterproductive.

1. Set client setting locale [userSettings] to Auto or clear App Data
2. Set android system locale to English (United States) [es_US]
3. Set jellyfin server locale [uiCulture] to Spanish (México) [es-MX]

With serverSettings code:

• 2020-09-21 00:43:40.491 3417-3417/org.jellyfin.mobile.debug D/LocaleUtilsKt: Updated locale from [serverSettings], locale: 'es_MX'
• webView: English (United States) [es_US]
• settingsActivity: Spanish (México) [es_MX]

Without serverSettings code:

• 2020-09-21 00:49:29.693 3422-3422/org.jellyfin.mobile.debug D/LocaleUtilsKt$initLocale: Couldn't acquire locale from config, keeping current
• webView: English (United States) [es_US]
• settingsActivity: English (United States) [es_US]

[Maxr1998]

@CarlosOlivo So I should just keep the user settings source for locale?

[CarlosOlivo]

@CarlosOlivo So I should just keep the user settings source for locale?

Yep, when no language is set in user settings the web UI fallback to system locale, not to uiCulture locale.

https://github.com/jellyfin/jellyfin-web/blob/7f8019d01f73a235edbd3e7872cf44310ce013e1/src/scripts/globalize.js#L39

https://github.com/jellyfin/jellyfin-web/blob/7f8019d01f73a235edbd3e7872cf44310ce013e1/src/scripts/globalize.js#L20

That is the default behavior.