Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use constants for intent actions and extras #30

Merged
merged 1 commit into from
Aug 20, 2020
Merged

Use constants for intent actions and extras #30

merged 1 commit into from
Aug 20, 2020

Conversation

Maxr1998
Copy link
Member

No description provided.

@Maxr1998 Maxr1998 added the enhancement New feature or request label Aug 20, 2020
nielsvanvelzen
nielsvanvelzen approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@nielsvanvelzen nielsvanvelzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer having the constants in the relevant file instead of one big constants file but the changes look good.

@Maxr1998
Copy link
Member Author

I prefer having the constants in the relevant file instead of one big constants file but the changes look good.

It depends, in this case the constants span multiple files, and I prefer to keep files concise, and not bloat them with constant declarations.

@nielsvanvelzen nielsvanvelzen merged commit ac247da into master Aug 20, 2020
@nielsvanvelzen nielsvanvelzen deleted the music-player-intent-constants branch August 20, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsvanvelzen nielsvanvelzen nielsvanvelzen approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Maxr1998 @nielsvanvelzen