Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using when construct #35

Merged
merged 2 commits into from
Aug 23, 2020
Merged

Using when construct #35

merged 2 commits into from
Aug 23, 2020

Conversation

andresesfm
Copy link
Contributor

recommended when construct, is easier to read

Maxr1998
Maxr1998 approved these changes Aug 22, 2020
View reviewed changes
Copy link
Member

@Maxr1998 Maxr1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the formatting issue Niels mentioned, LGTM.

@nielsvanvelzen nielsvanvelzen merged commit 1790d3a into jellyfin:master Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsvanvelzen nielsvanvelzen nielsvanvelzen approved these changes

@Maxr1998 Maxr1998 Maxr1998 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andresesfm @nielsvanvelzen @Maxr1998