Add release candidate number to version code #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maxr1998
requested changes
Aug 23, 2020
| @@ -1,7 +1,5 @@ | |||
| include(":app") | |||
|
|
|||
| rootProject.name = "Jellyfin" | |||
There was a problem hiding this comment.
It doesn't do anything except telling IntelliJ/Android Studio to name the project "Jellyfin" in all places (which is annoying when I have multiple Jellyfin projects, just use the directory name please)
There was a problem hiding this comment.
Fair enough, we could change that to Jellyfin Android though.
|
I did change your suggestions a bit for readability purposes, new sample: https://pl.kotl.in/HHFXfYGOA |
Maxr1998
approved these changes
Aug 23, 2020
|
The line would be quite long so this looked better to me |
It's barely longer than the comment, but still true. Gonna merge then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See documented code and Kotlin Playground sample which includes a test: https://pl.kotl.in/O_ZNvkGbQ