Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add splash screen #915

Merged
merged 3 commits into from
Dec 4, 2022
Merged

Add splash screen #915

merged 3 commits into from
Dec 4, 2022

Conversation

susonthapa
Copy link
Contributor

Changes
This PR adds a splash screen to the app. This is useful when the app takes time to start(during a cold start or if the user's device is slow). Android 12 automatically uses the app's icon as the window background so that users are not left with a blank screen but still it is a good idea to add a splash screen.

Before
Here is a simulated situation when the app takes more than 5 seconds to initialize.

API - 22

Kapture.2022-12-03.at.19.11.31.mp4

After
API - 22

Kapture.2022-12-03.at.18.57.03.mp4

For Android 12 and higher, there is no difference but the splash screen background will respect the device's dark mode settings.

API - 32
Dark Mode

Kapture.2022-12-03.at.18.57.57.mp4

Light Mode

Kapture.2022-12-03.at.18.58.36.mp4

Issues
Relates #900

@jellyfin-bot jellyfin-bot added this to the v2.5.0 milestone Dec 3, 2022
@Maxr1998
Copy link
Member

Maxr1998 commented Dec 4, 2022

I'm not partial to the white backgrounds in light theme when the rest of the app is always in dark mode, and the pixelated launcher icon on lower API levels isn't ideal either…
Both can be easily fixed, I just need to generate some bitmap icons because gradients aren't supported in vector drawables before API 24…

Always use dark background and use vector drawable without border as icon. On Android versions below N, the icon gradient is replaced with a solid white color since gradients in vector drawables aren't supported there.
@Maxr1998
Copy link
Member

Maxr1998 commented Dec 4, 2022

Ended up doing it slightly differently, Android N+ will see the normal icon with gradient, while versions below will have a solid white vector logo. Thus, it's still very sharp, and we don't have to ship a ton of bitmaps for ancient Android versions.

@Maxr1998 Maxr1998 enabled auto-merge (squash) December 4, 2022 21:03
@Maxr1998 Maxr1998 merged commit 5cc2483 into jellyfin:master Dec 4, 2022
@Maxr1998 Maxr1998 added the enhancement New feature or request label May 13, 2023
@Maxr1998 Maxr1998 changed the title Adds splash screen Add splash screen May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants