Add swipe gesture exclusion size preference #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacataldo
commented
Mar 20, 2023
| @@ -90,6 +90,7 @@ | |||
| <string name="pref_exoplayer_start_landscape_video_in_landscape">Start landscape mode videos in landscape orientation</string> | |||
| <string name="pref_exoplayer_allow_brightness_volume_gesture">Brightness and volume gestures</string> | |||
| <string name="pref_exoplayer_remember_brightness">Remember display brightness</string> | |||
| <string name="pref_exoplayer_swipe_exclusion_size_vertical">Gesture dead zone</string> | |||
There was a problem hiding this comment.
Not sure what the desired label would be here
Maxr1998
reviewed
Apr 4, 2023
| @@ -91,6 +91,9 @@ class AppPreferences(context: Context) { | |||
| val exoPlayerAllowSwipeGestures: Boolean | |||
| get() = sharedPreferences.getBoolean(Constants.PREF_EXOPLAYER_ALLOW_SWIPE_GESTURES, true) | |||
|
|
|||
| val exoPlayerSwipeExclusionSizeVertical: Int | |||
| get() = sharedPreferences.getInt(Constants.PREF_EXOPLAYER_SWIPE_GESTURE_EXCLUSION_SIZE_VERTICAL, 64) | |||
There was a problem hiding this comment.
Suggested change
| get() = sharedPreferences.getInt(Constants.PREF_EXOPLAYER_SWIPE_GESTURE_EXCLUSION_SIZE_VERTICAL, 64) | |
| get() = sharedPreferences.getInt(Constants.PREF_EXOPLAYER_SWIPE_GESTURE_EXCLUSION_SIZE_VERTICAL, 64) |
I think you could still use the previous constant here.
| @@ -35,6 +35,7 @@ object Constants { | |||
| const val PREF_VIDEO_PLAYER_TYPE = "pref_video_player_type" | |||
| const val PREF_EXOPLAYER_START_LANDSCAPE_VIDEO_IN_LANDSCAPE = "pref_exoplayer_start_landscape_video_in_landscape" | |||
| const val PREF_EXOPLAYER_ALLOW_SWIPE_GESTURES = "pref_exoplayer_allow_swipe_gestures" | |||
| const val PREF_EXOPLAYER_SWIPE_GESTURE_EXCLUSION_SIZE_VERTICAL = "pref_exoplayer_swipe_exclusion_size_vertical" | |||
There was a problem hiding this comment.
Idk why I originally named it like that, but this is better:
Suggested change
| const val PREF_EXOPLAYER_SWIPE_GESTURE_EXCLUSION_SIZE_VERTICAL = "pref_exoplayer_swipe_exclusion_size_vertical" | |
| const val PREF_EXOPLAYER_SWIPE_GESTURE_EXCLUSION_ZONE_HEIGHT = "pref_exoplayer_swipe_exclusion_zone_height" |
Please rename the constant/preference/string name in other places as well.
| @@ -101,7 +102,6 @@ object Constants { | |||
| const val TICKS_PER_MILLISECOND = 10000 | |||
| const val PLAYER_TIME_UPDATE_RATE = 10000L | |||
| const val DEFAULT_CONTROLS_TIMEOUT_MS = 2500 | |||
| const val SWIPE_GESTURE_EXCLUSION_SIZE_VERTICAL = 64 | |||
There was a problem hiding this comment.
Should be kept and used as a default for the preference, see above.
| @@ -90,6 +90,7 @@ | |||
| <string name="pref_exoplayer_start_landscape_video_in_landscape">Start landscape mode videos in landscape orientation</string> | |||
| <string name="pref_exoplayer_allow_brightness_volume_gesture">Brightness and volume gestures</string> | |||
| <string name="pref_exoplayer_remember_brightness">Remember display brightness</string> | |||
| <string name="pref_exoplayer_swipe_exclusion_size_vertical">Gesture dead zone</string> | |||
Maxr1998
reviewed
Apr 4, 2023
Comment on lines
+124
to
+127
| min = 0 | ||
| default = 64 | ||
| max = 128 | ||
| step = 8 |
There was a problem hiding this comment.
Preferably use constants here as well.
Maxr1998
reviewed
Apr 4, 2023
| step = 8 | ||
| enabled = appPreferences.videoPlayerType == VideoPlayerType.EXO_PLAYER && appPreferences.exoPlayerAllowSwipeGestures | ||
| } | ||
|
|
Maxr1998
reviewed
Apr 4, 2023
| @@ -97,6 +99,7 @@ class SettingsFragment : Fragment() { | |||
| defaultOnSelectionChange { selection -> | |||
| startLandscapeVideoInLandscapePreference.enabled = selection == VideoPlayerType.EXO_PLAYER | |||
| swipeGesturesPreference.enabled = selection == VideoPlayerType.EXO_PLAYER | |||
| swipeExclusionZoneVertical.enabled = selection == VideoPlayerType.EXO_PLAYER | |||
There was a problem hiding this comment.
Suggested change
| swipeExclusionZoneVertical.enabled = selection == VideoPlayerType.EXO_PLAYER | |
| swipeExclusionZoneVertical.enabled = selection == VideoPlayerType.EXO_PLAYER && swipeGesturesPreference.checked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds preference to modify the existing
SWIPE_GESTURE_EXCLUSION_SIZE_VERTICALconstant, allowing the user to configure the size of the vertical exclusion zone when using ExoPlayer. Also implemented the necessary conditionals to enable / disable this setting based on other relevant settings. Retains the current default value of64, allows for a range between 0-128.NOTE:
SWIPE_GESTURE_EXCLUSION_SIZE_VERTICALwas changed toPREF_EXOPLAYER_SWIPE_GESTURE_EXCLUSION_SIZE_VERTICALto better conform with existing conventions - let me know if a different name is desired.Issues
Implements #994