repo.ref("HEAD") -> KeyError

[brosner]

I am new to the code base and have been trying to get my head around it (though pretty easy to follow along).

With the repo I am working with I am seeing this:

>>> from dulwich.repo import Repo
>>> repo = Repo("<my bare repo path>")
>>> repo.head()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/brian/Development/dulwich/dulwich/repo.py", line 308, in head
    return self.refs.follow('HEAD')
  File "/Users/brian/Development/dulwich/dulwich/repo.py", line 82, in follow
    return follow_ref(self, name)
  File "/Users/brian/Development/dulwich/dulwich/repo.py", line 65, in follow_ref
    return follow_ref(container, ref)
  File "/Users/brian/Development/dulwich/dulwich/repo.py", line 60, in follow_ref
    contents = container[name]
  File "/Users/brian/Development/dulwich/dulwich/repo.py", line 163, in __getitem__
    raise KeyError(name)
KeyError: 'refs/heads/master'

Digging in a bit deeper I see that refs/heads/master is a packed ref which is why it cannot find it in refs/heads. Is there any reason why Repo.head uses self.refs.follow over self.ref? Hence the title. ref looks in packed refs, but doesn't know what HEAD is equal to to pull out the right ref.

I am sort of lost in the implementation to find the correct place to solve this.

[jelmer]

AFAIK this has been fixed.