Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Push fails with unsupported capabilities #977

Closed
danchr opened this issue Jun 8, 2022 · 1 comment
Closed

Push fails with unsupported capabilities #977

danchr opened this issue Jun 8, 2022 · 1 comment

Comments

@danchr
Copy link
Contributor

danchr commented Jun 8, 2022 •
edited
Loading

Hi

I have a test in hg-git that checks interacting with a repository, served by Dulwich itself. Unfortunately, that test fails with recent releases; somehow, pushing triggers this error:

dulwich.errors.GitProtocolError: Client asked for capability b'side-band' that was not advertised.

As best I can tell, there's no logic related to capabilities in hg-git, so the error seems somewhat surprising. Bisecting recent history reveals that the bug is caused by commit e9faf83, and undoing its changes fixes the test.

What are your thoughts on this? Is this a regression in Dulwich, or is there something we're doing wrong?

Thanks

— Dan
@danchr
Copy link
Contributor Author

danchr commented Jun 8, 2022

Digging into this, it somehow seems that the last four bytes of the final capability, `side-band-64k', somehow get swallowed

@danchr danchr mentioned this issue Jun 10, 2022
Merged
@danchr danchr mentioned this issue Jun 13, 2022
Closed
danchr added a commit to danchr/dulwich that referenced this issue Jun 13, 2022
@danchr
Fix pushing to a repository served by Dulwich itself
0f70b09 
This contains a backout/revert of commit e9faf83, which broke
pushing to a Dulwich-served repository using Dulwich itself. The
hg-git testsuite was affected by this; it broke one of our tests.

Fixes jelmer#977
danchr added a commit to danchr/hg-git that referenced this issue Jun 13, 2022
@danchr
tests: suppress push in test-service-dulwich.t for recent releases
4c4f20b 
Pushing to Dulwich itself is broken in recent releases; I've posted a
PR that should fix that, so we assume the next release will fix it.

jelmer/dulwich#977

--HG--
branch : 1.0.x
@jelmer jelmer closed this as completed in 31490d6 Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix pushing to a repository served by Dulwich itself danchr/dulwich
1 participant
@danchr